From: Adrian Hunter <adrian.hunter@intel.com>
To: Leo Yan <leo.yan@arm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
John Garry <john.g.garry@oracle.com>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
coresight@lists.linaro.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 2/4] perf auxtrace: Remove unused 'pmu' pointer from struct auxtrace_record
Date: Thu, 25 Jul 2024 18:51:56 +0300 [thread overview]
Message-ID: <dfc486a3-fc69-4ae5-a1c2-768bae92f70b@intel.com> (raw)
In-Reply-To: <20240725064620.1651819-3-leo.yan@arm.com>
On 25/07/24 09:46, Leo Yan wrote:
> The 'pmu' pointer in the auxtrace_record structure is not used after
> support multiple AUX events, remove it.
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Signed-off-by: Leo Yan <leo.yan@arm.com>
> ---
> tools/perf/arch/arm/util/cs-etm.c | 1 -
> tools/perf/arch/arm64/util/arm-spe.c | 1 -
> tools/perf/arch/arm64/util/hisi-ptt.c | 1 -
> tools/perf/arch/x86/util/intel-bts.c | 1 -
> tools/perf/arch/x86/util/intel-pt.c | 1 -
> tools/perf/util/auxtrace.h | 1 -
> 6 files changed, 6 deletions(-)
>
> diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c
> index da6231367993..96aeb7cdbee1 100644
> --- a/tools/perf/arch/arm/util/cs-etm.c
> +++ b/tools/perf/arch/arm/util/cs-etm.c
> @@ -888,7 +888,6 @@ struct auxtrace_record *cs_etm_record_init(int *err)
> }
>
> ptr->cs_etm_pmu = cs_etm_pmu;
> - ptr->itr.pmu = cs_etm_pmu;
> ptr->itr.parse_snapshot_options = cs_etm_parse_snapshot_options;
> ptr->itr.recording_options = cs_etm_recording_options;
> ptr->itr.info_priv_size = cs_etm_info_priv_size;
> diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c
> index 0b52e67edb3b..622fd47573ec 100644
> --- a/tools/perf/arch/arm64/util/arm-spe.c
> +++ b/tools/perf/arch/arm64/util/arm-spe.c
> @@ -497,7 +497,6 @@ struct auxtrace_record *arm_spe_recording_init(int *err,
> }
>
> sper->arm_spe_pmu = arm_spe_pmu;
> - sper->itr.pmu = arm_spe_pmu;
> sper->itr.snapshot_start = arm_spe_snapshot_start;
> sper->itr.snapshot_finish = arm_spe_snapshot_finish;
> sper->itr.find_snapshot = arm_spe_find_snapshot;
> diff --git a/tools/perf/arch/arm64/util/hisi-ptt.c b/tools/perf/arch/arm64/util/hisi-ptt.c
> index ba97c8a562a0..eac9739c87e6 100644
> --- a/tools/perf/arch/arm64/util/hisi-ptt.c
> +++ b/tools/perf/arch/arm64/util/hisi-ptt.c
> @@ -174,7 +174,6 @@ struct auxtrace_record *hisi_ptt_recording_init(int *err,
> }
>
> pttr->hisi_ptt_pmu = hisi_ptt_pmu;
> - pttr->itr.pmu = hisi_ptt_pmu;
> pttr->itr.recording_options = hisi_ptt_recording_options;
> pttr->itr.info_priv_size = hisi_ptt_info_priv_size;
> pttr->itr.info_fill = hisi_ptt_info_fill;
> diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
> index 34696f3d3d5d..85c8186300c8 100644
> --- a/tools/perf/arch/x86/util/intel-bts.c
> +++ b/tools/perf/arch/x86/util/intel-bts.c
> @@ -434,7 +434,6 @@ struct auxtrace_record *intel_bts_recording_init(int *err)
> }
>
> btsr->intel_bts_pmu = intel_bts_pmu;
> - btsr->itr.pmu = intel_bts_pmu;
> btsr->itr.recording_options = intel_bts_recording_options;
> btsr->itr.info_priv_size = intel_bts_info_priv_size;
> btsr->itr.info_fill = intel_bts_info_fill;
> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
> index 4b710e875953..ea510a7486b1 100644
> --- a/tools/perf/arch/x86/util/intel-pt.c
> +++ b/tools/perf/arch/x86/util/intel-pt.c
> @@ -1197,7 +1197,6 @@ struct auxtrace_record *intel_pt_recording_init(int *err)
> }
>
> ptr->intel_pt_pmu = intel_pt_pmu;
> - ptr->itr.pmu = intel_pt_pmu;
> ptr->itr.recording_options = intel_pt_recording_options;
> ptr->itr.info_priv_size = intel_pt_info_priv_size;
> ptr->itr.info_fill = intel_pt_info_fill;
> diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
> index f99e53426528..a54f7b99ba5a 100644
> --- a/tools/perf/util/auxtrace.h
> +++ b/tools/perf/util/auxtrace.h
> @@ -411,7 +411,6 @@ struct auxtrace_record {
> int (*read_finish)(struct auxtrace_record *itr, int idx);
> unsigned int alignment;
> unsigned int default_aux_sample_size;
> - struct perf_pmu *pmu;
> struct evlist *evlist;
> };
>
next prev parent reply other threads:[~2024-07-25 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 6:46 [PATCH v2 0/4] perf auxtrace: Support multiple AUX events Leo Yan
2024-07-25 6:46 ` [PATCH v2 1/4] perf auxtrace: Iterate all AUX events when finish reading Leo Yan
2024-07-25 15:40 ` Adrian Hunter
2024-07-29 8:48 ` Leo Yan
2024-07-30 19:28 ` Arnaldo Carvalho de Melo
2024-07-25 6:46 ` [PATCH v2 2/4] perf auxtrace: Remove unused 'pmu' pointer from struct auxtrace_record Leo Yan
2024-07-25 15:51 ` Adrian Hunter [this message]
2024-07-25 6:46 ` [PATCH v2 3/4] perf arm-spe: Extract evsel setting up Leo Yan
2024-07-25 6:46 ` [PATCH v2 4/4] perf arm-spe: Support multiple Arm SPE events Leo Yan
2024-07-25 7:06 ` [PATCH v2 0/4] perf auxtrace: Support multiple AUX events Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfc486a3-fc69-4ae5-a1c2-768bae92f70b@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).