linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] perf tests kallsyms: Fix missed map__put
@ 2025-12-10 19:01 Ian Rogers
  2025-12-12 15:19 ` James Clark
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2025-12-10 19:01 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Namhyung Kim, Jiri Olsa, Ian Rogers, James Clark,
	linux-perf-users, linux-kernel
  Cc: kernel test robot

Issue was caught by leak sanitizer and the test robot.

Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202512101502.f3819cd3-lkp@intel.com
Fixes: 34e271ae5538 ("perf test: Add kallsyms split test")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/kallsyms-split.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/kallsyms-split.c b/tools/perf/tests/kallsyms-split.c
index bbbc66957e5d..117ed3b70f63 100644
--- a/tools/perf/tests/kallsyms-split.c
+++ b/tools/perf/tests/kallsyms-split.c
@@ -148,6 +148,7 @@ static int test__kallsyms_split(struct test_suite *test __maybe_unused,
 	ret = TEST_OK;
 
 out:
+	map__put(map);
 	remove_proc_dir(0);
 	machine__exit(&m);
 	return ret;
-- 
2.52.0.223.gf5cc29aaa4-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] perf tests kallsyms: Fix missed map__put
  2025-12-10 19:01 [PATCH v1] perf tests kallsyms: Fix missed map__put Ian Rogers
@ 2025-12-12 15:19 ` James Clark
  0 siblings, 0 replies; 2+ messages in thread
From: James Clark @ 2025-12-12 15:19 UTC (permalink / raw)
  To: Ian Rogers
  Cc: kernel test robot, Peter Zijlstra, Ingo Molnar,
	Arnaldo Carvalho de Melo, Namhyung Kim, Jiri Olsa,
	linux-perf-users, linux-kernel



On 10/12/2025 21:01, Ian Rogers wrote:
> Issue was caught by leak sanitizer and the test robot.
> 
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202512101502.f3819cd3-lkp@intel.com
> Fixes: 34e271ae5538 ("perf test: Add kallsyms split test")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>   tools/perf/tests/kallsyms-split.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/kallsyms-split.c b/tools/perf/tests/kallsyms-split.c
> index bbbc66957e5d..117ed3b70f63 100644
> --- a/tools/perf/tests/kallsyms-split.c
> +++ b/tools/perf/tests/kallsyms-split.c
> @@ -148,6 +148,7 @@ static int test__kallsyms_split(struct test_suite *test __maybe_unused,
>   	ret = TEST_OK;
>   
>   out:
> +	map__put(map);
>   	remove_proc_dir(0);
>   	machine__exit(&m);
>   	return ret;

Reviewed-by: James Clark <james.clark@linaro.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-12 15:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-10 19:01 [PATCH v1] perf tests kallsyms: Fix missed map__put Ian Rogers
2025-12-12 15:19 ` James Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).