From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA65C77B7C for ; Mon, 1 May 2023 23:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231397AbjEAXed (ORCPT ); Mon, 1 May 2023 19:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbjEAXec (ORCPT ); Mon, 1 May 2023 19:34:32 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E25261FCC; Mon, 1 May 2023 16:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682984071; x=1714520071; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Q5lAfm4ntOimWR0yBsZWpkkaD5go1ON+6b95VO5UqNA=; b=KvRzz3A4zrEL8OIc8AIyF9JU6JaaKhtAa7LI8Yy+yEx5+e8YoZjAoH11 HTnZEYhGuw9bcoeetaCb3TVo2q5kuJxfeqllRpTQh5pdGWkbd1POPkosr sGlZx05L0oWt9Nk/W61kiAmSyH+99cYuPxsx2O337EmCogPaiVf38OBTL 3AyV3NecCdnKkEiPsi0ZByWr5n89umXMcrXAsSjx6UNc3hbpIRPckg7y/ nbWQPUK8rkcLxeFaetT+vyEguh3/5pzkneG4i/K5f3tsBmszgcFmEnsP5 mbH5vpRLvx3aHDHWBjmihdBip8VhC4Nr/y/QFBCq7sd4S1WbefH2y8y6P w==; X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="376319224" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="376319224" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2023 16:34:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="695961196" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="695961196" Received: from linux.intel.com ([10.54.29.200]) by orsmga002.jf.intel.com with ESMTP; 01 May 2023 16:34:30 -0700 Received: from [10.209.15.48] (kliang2-mobl1.ccr.corp.intel.com [10.209.15.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 38328580B0E; Mon, 1 May 2023 16:34:27 -0700 (PDT) Message-ID: Date: Mon, 1 May 2023 19:34:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 03/46] perf stat: Introduce skippable evsels Content-Language: en-US To: Ian Rogers , Stephane Eranian Cc: Weilin Wang , Arnaldo Carvalho de Melo , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230429053506.1962559-1-irogers@google.com> <20230429053506.1962559-4-irogers@google.com> From: "Liang, Kan" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 2023-05-01 4:48 p.m., Ian Rogers wrote: > On Mon, May 1, 2023 at 1:25 PM Liang, Kan wrote: >> >> >> On 2023-05-01 11:29 a.m., Ian Rogers wrote: >>> The events are displayed twice as there are 2 groups of events. This >>> is changed by: >>> https://lore.kernel.org/lkml/20230429053506.1962559-5-irogers@google.com/ >>> where the events are no longer grouped. >> The trick seems don't work on a hybrid machine. I still got the >> duplicate Topdown events on e-core. > For hybrid the rest of the patch series is necessary, ie the patches > beyond what's for 6.4, which I take from the output (ie not a crash) > you are looking at. As multiple groups are in play then it looks like > the atom events are on >1 PMU which can happen as the x86 code special > cases events with topdown in their name. Some fixes in the series for > this are: > https://lore.kernel.org/lkml/20230429053506.1962559-6-irogers@google.com/ > https://lore.kernel.org/lkml/20230429053506.1962559-40-irogers@google.com/ > and related: > https://lore.kernel.org/lkml/20230429053506.1962559-19-irogers@google.com/ > and so fixing this requires some detective work. > I applied all the patches of the series when I did the test on hybrid. The above patches don't help. > I don't think it should be a requirement for the series that all > hybrid bugs are fixed - especially given the complaints against the > length of the series as-is. I agree especially considering the metrics have been broken on the hybrid for a while. I just want to do a complete test and understand what is going to fixed and what hasn't. Thanks, Kan