linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] perf vendor events arm64: Add some missing content for Hisi hip08 json
@ 2025-04-16  2:02 Junhao He
  2025-04-16  2:02 ` [PATCH 1/2] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu Junhao He
  2025-04-16  2:02 ` [PATCH 2/2] MAINTAINERS: Add hisilicon pmu json events under its entry Junhao He
  0 siblings, 2 replies; 6+ messages in thread
From: Junhao He @ 2025-04-16  2:02 UTC (permalink / raw)
  To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
	jolsa, irogers, james.clark, linux-perf-users, linux-kernel,
	leo.yan, john.g.garry, will, mike.leach, yangyicong,
	jonathan.cameron
  Cc: linuxarm, hejunhao3

Add missing field for Hisi hip08 json and list hisilicon pmu json
events under the its entry to MAINTAINERS.

Junhao He (2):
  perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu
  MAINTAINERS: Add hisilicon pmu json events under its entry

 MAINTAINERS                                   |  1 +
 .../arm64/hisilicon/hip08/uncore-hha.json     | 32 +++++++++++++++++++
 2 files changed, 33 insertions(+)

-- 
2.33.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu
  2025-04-16  2:02 [PATCH 0/2] perf vendor events arm64: Add some missing content for Hisi hip08 json Junhao He
@ 2025-04-16  2:02 ` Junhao He
  2025-04-16 13:17   ` James Clark
  2025-04-16  2:02 ` [PATCH 2/2] MAINTAINERS: Add hisilicon pmu json events under its entry Junhao He
  1 sibling, 1 reply; 6+ messages in thread
From: Junhao He @ 2025-04-16  2:02 UTC (permalink / raw)
  To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
	jolsa, irogers, james.clark, linux-perf-users, linux-kernel,
	leo.yan, john.g.garry, will, mike.leach, yangyicong,
	jonathan.cameron
  Cc: linuxarm, hejunhao3

In the same PMU, when some JSON events have the "BriefDescription" field
populated while others do not, the cmp_sevent() function will split these
two types of events into separate groups. As a result, when using perf
list to display events, the two types of events cannot be grouped together
in the output.

before patch:
 $ perf list
 ...
 uncore hha:
   hisi_sccl1_hha2/sdir-hit/
   hisi_sccl1_hha2/sdir-lookup/
 ...
 uncore hha:
   edir-hit
      [Count of The number of HHA E-Dir hit operations. Unit: hisi_sccl,hha]

after patch:
 $ perf list
 ...
 uncore hha:
   edir-hit
      [Count of The number of HHA E-Dir hit operations. Unit: hisi_sccl,hha]
   sdir-hit
      [Count of The number of HHA S-Dir hit operations. Unit: hisi_sccl,hha]
   sdir-lookup
      [Count of the number of HHA S-Dir lookup operations. Unit: hisi_sccl,hha]

Signed-off-by: Junhao He <hejunhao3@huawei.com>
---
 .../arm64/hisilicon/hip08/uncore-hha.json     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
index 9a7ec7af2060..5ac8f919b498 100644
--- a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
+++ b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
@@ -30,15 +30,21 @@
    {
 	    "ConfigCode": "0x4",
 	    "EventName": "rx_wbi",
+	    "BriefDescription": "Count of the number of WriteBackI operations that HHA has received",
+	    "PublicDescription": "Count of the number of WriteBackI operations that HHA has received",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x5",
 	    "EventName": "rx_wbip",
+	    "BriefDescription": "Count of the number of WriteBackIPtl operations that HHA has received",
+	    "PublicDescription": "Count of the number of WriteBackIPtl operations that HHA has received",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x11",
+	    "BriefDescription": "Count of the number of WriteThruIStash operations that HHA has received",
+	    "PublicDescription": "Count of the number of WriteThruIStash operations that HHA has received",
 	    "EventName": "rx_wtistash",
 	    "Unit": "hisi_sccl,hha"
    },
@@ -87,66 +93,92 @@
    {
 	    "ConfigCode": "0x23",
 	    "EventName": "bi_num",
+	    "BriefDescription": "Count of the number of HHA BackInvalid operations",
+	    "PublicDescription": "Count of the number of HHA BackInvalid operations",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x32",
 	    "EventName": "mediated_num",
+	    "BriefDescription": "Count of the number of Mediated operations that the HHA has forwarded",
+	    "PublicDescription": "Count of the number of Mediated operations that the HHA has forwarded",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x33",
 	    "EventName": "tx_snp_num",
+	    "BriefDescription": "Count of the number of Snoop operations that the HHA has sent",
+	    "PublicDescription": "Count of the number of Snoop operations that the HHA has sent",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x34",
 	    "EventName": "tx_snp_outer",
+	    "BriefDescription": "Count of the number of Snoop operations that the HHA has sent to another socket",
+	    "PublicDescription": "Count of the number of Snoop operations that the HHA has sent to another socket",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x35",
 	    "EventName": "tx_snp_ccix",
+	    "BriefDescription": "Count of the number of Snoop operations that the HHA has sent to CCIX",
+	    "PublicDescription": "Count of the number of Snoop operations that the HHA has sent to CCIX",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x38",
 	    "EventName": "rx_snprspdata",
+	    "BriefDescription": "Count of the number of SnprspData flit operations that HHA has received",
+	    "PublicDescription": "Count of the number of SnprspData flit operations that HHA has received",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x3c",
 	    "EventName": "rx_snprsp_outer",
+	    "BriefDescription": "Count of the number of SnprspData operations that HHA has received from another socket",
+	    "PublicDescription": "Count of the number of SnprspData operations that HHA has received from another socket",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x40",
 	    "EventName": "sdir-lookup",
+	    "BriefDescription": "Count of the number of HHA S-Dir lookup operations",
+	    "PublicDescription": "Count of the number of HHA S-Dir lookup operations",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x41",
 	    "EventName": "edir-lookup",
+	    "BriefDescription": "Count of the number of HHA E-Dir lookup operations",
+	    "PublicDescription": "Count of the number of HHA E-Dir lookup operations",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x42",
 	    "EventName": "sdir-hit",
+	    "BriefDescription": "Count of the number of HHA S-Dir hit operations",
+	    "PublicDescription": "Count of the number of HHA S-Dir hit operations",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x43",
 	    "EventName": "edir-hit",
+	    "BriefDescription": "Count of the number of HHA E-Dir hit operations",
+	    "PublicDescription": "Count of the number of HHA E-Dir hit operations",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x4c",
 	    "EventName": "sdir-home-migrate",
+	    "BriefDescription": "Count of the number of HHA S-Dir read home migrate operations",
+	    "PublicDescription": "Count of the number of HHA S-Dir read home migrate operations",
 	    "Unit": "hisi_sccl,hha"
    },
    {
 	    "ConfigCode": "0x4d",
 	    "EventName": "edir-home-migrate",
+	    "BriefDescription": "Count of the number of HHA E-Dir read home migrate operations",
+	    "PublicDescription": "Count of the number of HHA E-Dir read home migrate operations",
 	    "Unit": "hisi_sccl,hha"
    }
 ]
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] MAINTAINERS: Add hisilicon pmu json events under its entry
  2025-04-16  2:02 [PATCH 0/2] perf vendor events arm64: Add some missing content for Hisi hip08 json Junhao He
  2025-04-16  2:02 ` [PATCH 1/2] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu Junhao He
@ 2025-04-16  2:02 ` Junhao He
  2025-04-16 13:18   ` James Clark
  1 sibling, 1 reply; 6+ messages in thread
From: Junhao He @ 2025-04-16  2:02 UTC (permalink / raw)
  To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
	jolsa, irogers, james.clark, linux-perf-users, linux-kernel,
	leo.yan, john.g.garry, will, mike.leach, yangyicong,
	jonathan.cameron
  Cc: linuxarm, hejunhao3

The all hisilicon pmu json events were missing to be listed there.

Signed-off-by: Junhao He <hejunhao3@huawei.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 00ff21b955bc..bf9588a94919 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10474,6 +10474,7 @@ W:	http://www.hisilicon.com
 F:	Documentation/admin-guide/perf/hisi-pcie-pmu.rst
 F:	Documentation/admin-guide/perf/hisi-pmu.rst
 F:	drivers/perf/hisilicon
+F:	tools/perf/pmu-events/arch/arm64/hisilicon/
 
 HISILICON PTT DRIVER
 M:	Yicong Yang <yangyicong@hisilicon.com>
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu
  2025-04-16  2:02 ` [PATCH 1/2] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu Junhao He
@ 2025-04-16 13:17   ` James Clark
  2025-04-17  9:05     ` hejunhao
  0 siblings, 1 reply; 6+ messages in thread
From: James Clark @ 2025-04-16 13:17 UTC (permalink / raw)
  To: Junhao He
  Cc: linuxarm, peterz, mingo, acme, namhyung, mark.rutland,
	alexander.shishkin, jolsa, irogers, linux-perf-users,
	linux-kernel, leo.yan, john.g.garry, will, mike.leach, yangyicong,
	jonathan.cameron



On 16/04/2025 3:02 am, Junhao He wrote:
> In the same PMU, when some JSON events have the "BriefDescription" field
> populated while others do not, the cmp_sevent() function will split these
> two types of events into separate groups. As a result, when using perf
> list to display events, the two types of events cannot be grouped together
> in the output.
> 

Hi Junhao,

I think just the first patch here [1] might have helped for this issue. 
It would result in them being grouped together, although one would still 
be missing the description so your change is ok either way.

[1]: 
https://lore.kernel.org/lkml/20250304-james-perf-hybrid-list-v1-1-a363ffac283c@linaro.org/

> before patch:
>   $ perf list
>   ...
>   uncore hha:
>     hisi_sccl1_hha2/sdir-hit/
>     hisi_sccl1_hha2/sdir-lookup/
>   ...
>   uncore hha:
>     edir-hit
>        [Count of The number of HHA E-Dir hit operations. Unit: hisi_sccl,hha]
> 
> after patch:
>   $ perf list
>   ...
>   uncore hha:
>     edir-hit
>        [Count of The number of HHA E-Dir hit operations. Unit: hisi_sccl,hha]
>     sdir-hit
>        [Count of The number of HHA S-Dir hit operations. Unit: hisi_sccl,hha]
>     sdir-lookup
>        [Count of the number of HHA S-Dir lookup operations. Unit: hisi_sccl,hha]
> 
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
> ---
>   .../arm64/hisilicon/hip08/uncore-hha.json     | 32 +++++++++++++++++++
>   1 file changed, 32 insertions(+)
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
> index 9a7ec7af2060..5ac8f919b498 100644
> --- a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
> +++ b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
> @@ -30,15 +30,21 @@
>      {
>   	    "ConfigCode": "0x4",
>   	    "EventName": "rx_wbi",
> +	    "BriefDescription": "Count of the number of WriteBackI operations that HHA has received",
> +	    "PublicDescription": "Count of the number of WriteBackI operations that HHA has received",

You only need BriefDescription if both are going to be the same. It will 
be used for both short and long form output.

With that:

Reviewed-by: James Clark <james.clark@linaro.org>

>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x5",
>   	    "EventName": "rx_wbip",
> +	    "BriefDescription": "Count of the number of WriteBackIPtl operations that HHA has received",
> +	    "PublicDescription": "Count of the number of WriteBackIPtl operations that HHA has received",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x11",
> +	    "BriefDescription": "Count of the number of WriteThruIStash operations that HHA has received",
> +	    "PublicDescription": "Count of the number of WriteThruIStash operations that HHA has received",
>   	    "EventName": "rx_wtistash",
>   	    "Unit": "hisi_sccl,hha"
>      },
> @@ -87,66 +93,92 @@
>      {
>   	    "ConfigCode": "0x23",
>   	    "EventName": "bi_num",
> +	    "BriefDescription": "Count of the number of HHA BackInvalid operations",
> +	    "PublicDescription": "Count of the number of HHA BackInvalid operations",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x32",
>   	    "EventName": "mediated_num",
> +	    "BriefDescription": "Count of the number of Mediated operations that the HHA has forwarded",
> +	    "PublicDescription": "Count of the number of Mediated operations that the HHA has forwarded",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x33",
>   	    "EventName": "tx_snp_num",
> +	    "BriefDescription": "Count of the number of Snoop operations that the HHA has sent",
> +	    "PublicDescription": "Count of the number of Snoop operations that the HHA has sent",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x34",
>   	    "EventName": "tx_snp_outer",
> +	    "BriefDescription": "Count of the number of Snoop operations that the HHA has sent to another socket",
> +	    "PublicDescription": "Count of the number of Snoop operations that the HHA has sent to another socket",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x35",
>   	    "EventName": "tx_snp_ccix",
> +	    "BriefDescription": "Count of the number of Snoop operations that the HHA has sent to CCIX",
> +	    "PublicDescription": "Count of the number of Snoop operations that the HHA has sent to CCIX",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x38",
>   	    "EventName": "rx_snprspdata",
> +	    "BriefDescription": "Count of the number of SnprspData flit operations that HHA has received",
> +	    "PublicDescription": "Count of the number of SnprspData flit operations that HHA has received",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x3c",
>   	    "EventName": "rx_snprsp_outer",
> +	    "BriefDescription": "Count of the number of SnprspData operations that HHA has received from another socket",
> +	    "PublicDescription": "Count of the number of SnprspData operations that HHA has received from another socket",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x40",
>   	    "EventName": "sdir-lookup",
> +	    "BriefDescription": "Count of the number of HHA S-Dir lookup operations",
> +	    "PublicDescription": "Count of the number of HHA S-Dir lookup operations",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x41",
>   	    "EventName": "edir-lookup",
> +	    "BriefDescription": "Count of the number of HHA E-Dir lookup operations",
> +	    "PublicDescription": "Count of the number of HHA E-Dir lookup operations",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x42",
>   	    "EventName": "sdir-hit",
> +	    "BriefDescription": "Count of the number of HHA S-Dir hit operations",
> +	    "PublicDescription": "Count of the number of HHA S-Dir hit operations",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x43",
>   	    "EventName": "edir-hit",
> +	    "BriefDescription": "Count of the number of HHA E-Dir hit operations",
> +	    "PublicDescription": "Count of the number of HHA E-Dir hit operations",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x4c",
>   	    "EventName": "sdir-home-migrate",
> +	    "BriefDescription": "Count of the number of HHA S-Dir read home migrate operations",
> +	    "PublicDescription": "Count of the number of HHA S-Dir read home migrate operations",
>   	    "Unit": "hisi_sccl,hha"
>      },
>      {
>   	    "ConfigCode": "0x4d",
>   	    "EventName": "edir-home-migrate",
> +	    "BriefDescription": "Count of the number of HHA E-Dir read home migrate operations",
> +	    "PublicDescription": "Count of the number of HHA E-Dir read home migrate operations",
>   	    "Unit": "hisi_sccl,hha"
>      }
>   ]


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] MAINTAINERS: Add hisilicon pmu json events under its entry
  2025-04-16  2:02 ` [PATCH 2/2] MAINTAINERS: Add hisilicon pmu json events under its entry Junhao He
@ 2025-04-16 13:18   ` James Clark
  0 siblings, 0 replies; 6+ messages in thread
From: James Clark @ 2025-04-16 13:18 UTC (permalink / raw)
  To: Junhao He
  Cc: linuxarm, peterz, mingo, acme, namhyung, mark.rutland,
	alexander.shishkin, jolsa, irogers, linux-perf-users,
	linux-kernel, leo.yan, john.g.garry, will, mike.leach, yangyicong,
	jonathan.cameron



On 16/04/2025 3:02 am, Junhao He wrote:
> The all hisilicon pmu json events were missing to be listed there.
> 
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 00ff21b955bc..bf9588a94919 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10474,6 +10474,7 @@ W:	http://www.hisilicon.com
>   F:	Documentation/admin-guide/perf/hisi-pcie-pmu.rst
>   F:	Documentation/admin-guide/perf/hisi-pmu.rst
>   F:	drivers/perf/hisilicon
> +F:	tools/perf/pmu-events/arch/arm64/hisilicon/
>   
>   HISILICON PTT DRIVER
>   M:	Yicong Yang <yangyicong@hisilicon.com>

Reviewed-by: James Clark <james.clark@linaro.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu
  2025-04-16 13:17   ` James Clark
@ 2025-04-17  9:05     ` hejunhao
  0 siblings, 0 replies; 6+ messages in thread
From: hejunhao @ 2025-04-17  9:05 UTC (permalink / raw)
  To: James Clark
  Cc: linuxarm, peterz, mingo, acme, namhyung, mark.rutland,
	alexander.shishkin, jolsa, irogers, linux-perf-users,
	linux-kernel, leo.yan, john.g.garry, will, mike.leach, yangyicong,
	jonathan.cameron, hejunhao


On 2025/4/16 21:17, James Clark wrote:
>
>
> On 16/04/2025 3:02 am, Junhao He wrote:
>> In the same PMU, when some JSON events have the "BriefDescription" field
>> populated while others do not, the cmp_sevent() function will split 
>> these
>> two types of events into separate groups. As a result, when using perf
>> list to display events, the two types of events cannot be grouped 
>> together
>> in the output.
>>
>
> Hi Junhao,
>
> I think just the first patch here [1] might have helped for this 
> issue. It would result in them being grouped together, although one 
> would still be missing the description so your change is ok either way.
>
> [1]: 
> https://lore.kernel.org/lkml/20250304-james-perf-hybrid-list-v1-1-a363ffac283c@linaro.org/
>

Hi James,

Thanks for the comments.

In the cmp_sevent() function [2], the comparison begins with checking 
sevent->desc.
Thus, the issue cannot be resolved by the patch [1].

Perhaps the simultaneous occurrence of hisi_sccl1_hha2 and hisi_sccl,hha 
is making this
commit hard to understand. This is part of the optimization I'm working 
on next, so
please ignore it for now. I will correct the PMU name and Unit in the 
next version.

[2]: 
https://elixir.bootlin.com/linux/v6.15-rc1/source/tools/perf/util/pmus.c#L435

>> before patch:
>>   $ perf list
>>   ...
>>   uncore hha:
>>     hisi_sccl1_hha2/sdir-hit/
>>     hisi_sccl1_hha2/sdir-lookup/
>>   ...
>>   uncore hha:
>>     edir-hit
>>        [Count of The number of HHA E-Dir hit operations. Unit: 
>> hisi_sccl,hha]
>>
>> after patch:
>>   $ perf list
>>   ...
>>   uncore hha:
>>     edir-hit
>>        [Count of The number of HHA E-Dir hit operations. Unit: 
>> hisi_sccl,hha]
>>     sdir-hit
>>        [Count of The number of HHA S-Dir hit operations. Unit: 
>> hisi_sccl,hha]
>>     sdir-lookup
>>        [Count of the number of HHA S-Dir lookup operations. Unit: 
>> hisi_sccl,hha]
>>
>> Signed-off-by: Junhao He <hejunhao3@huawei.com>
>> ---
>>   .../arm64/hisilicon/hip08/uncore-hha.json     | 32 +++++++++++++++++++
>>   1 file changed, 32 insertions(+)
>>
>> diff --git 
>> a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json 
>> b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
>> index 9a7ec7af2060..5ac8f919b498 100644
>> --- a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
>> +++ b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
>> @@ -30,15 +30,21 @@
>>      {
>>           "ConfigCode": "0x4",
>>           "EventName": "rx_wbi",
>> +        "BriefDescription": "Count of the number of WriteBackI 
>> operations that HHA has received",
>> +        "PublicDescription": "Count of the number of WriteBackI 
>> operations that HHA has received",
>
> You only need BriefDescription if both are going to be the same. It 
> will be used for both short and long form output.
>
> With that:
>
> Reviewed-by: James Clark <james.clark@linaro.org>
>

Ok, i will drop this PublicDescription.
I will append one new patch to drop other hip08 uncore PMU 
PublicDescriptions.

Best regards,
Junhao.

>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x5",
>>           "EventName": "rx_wbip",
>> +        "BriefDescription": "Count of the number of WriteBackIPtl 
>> operations that HHA has received",
>> +        "PublicDescription": "Count of the number of WriteBackIPtl 
>> operations that HHA has received",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x11",
>> +        "BriefDescription": "Count of the number of WriteThruIStash 
>> operations that HHA has received",
>> +        "PublicDescription": "Count of the number of WriteThruIStash 
>> operations that HHA has received",
>>           "EventName": "rx_wtistash",
>>           "Unit": "hisi_sccl,hha"
>>      },
>> @@ -87,66 +93,92 @@
>>      {
>>           "ConfigCode": "0x23",
>>           "EventName": "bi_num",
>> +        "BriefDescription": "Count of the number of HHA BackInvalid 
>> operations",
>> +        "PublicDescription": "Count of the number of HHA BackInvalid 
>> operations",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x32",
>>           "EventName": "mediated_num",
>> +        "BriefDescription": "Count of the number of Mediated 
>> operations that the HHA has forwarded",
>> +        "PublicDescription": "Count of the number of Mediated 
>> operations that the HHA has forwarded",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x33",
>>           "EventName": "tx_snp_num",
>> +        "BriefDescription": "Count of the number of Snoop operations 
>> that the HHA has sent",
>> +        "PublicDescription": "Count of the number of Snoop 
>> operations that the HHA has sent",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x34",
>>           "EventName": "tx_snp_outer",
>> +        "BriefDescription": "Count of the number of Snoop operations 
>> that the HHA has sent to another socket",
>> +        "PublicDescription": "Count of the number of Snoop 
>> operations that the HHA has sent to another socket",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x35",
>>           "EventName": "tx_snp_ccix",
>> +        "BriefDescription": "Count of the number of Snoop operations 
>> that the HHA has sent to CCIX",
>> +        "PublicDescription": "Count of the number of Snoop 
>> operations that the HHA has sent to CCIX",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x38",
>>           "EventName": "rx_snprspdata",
>> +        "BriefDescription": "Count of the number of SnprspData flit 
>> operations that HHA has received",
>> +        "PublicDescription": "Count of the number of SnprspData flit 
>> operations that HHA has received",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x3c",
>>           "EventName": "rx_snprsp_outer",
>> +        "BriefDescription": "Count of the number of SnprspData 
>> operations that HHA has received from another socket",
>> +        "PublicDescription": "Count of the number of SnprspData 
>> operations that HHA has received from another socket",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x40",
>>           "EventName": "sdir-lookup",
>> +        "BriefDescription": "Count of the number of HHA S-Dir lookup 
>> operations",
>> +        "PublicDescription": "Count of the number of HHA S-Dir 
>> lookup operations",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x41",
>>           "EventName": "edir-lookup",
>> +        "BriefDescription": "Count of the number of HHA E-Dir lookup 
>> operations",
>> +        "PublicDescription": "Count of the number of HHA E-Dir 
>> lookup operations",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x42",
>>           "EventName": "sdir-hit",
>> +        "BriefDescription": "Count of the number of HHA S-Dir hit 
>> operations",
>> +        "PublicDescription": "Count of the number of HHA S-Dir hit 
>> operations",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x43",
>>           "EventName": "edir-hit",
>> +        "BriefDescription": "Count of the number of HHA E-Dir hit 
>> operations",
>> +        "PublicDescription": "Count of the number of HHA E-Dir hit 
>> operations",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x4c",
>>           "EventName": "sdir-home-migrate",
>> +        "BriefDescription": "Count of the number of HHA S-Dir read 
>> home migrate operations",
>> +        "PublicDescription": "Count of the number of HHA S-Dir read 
>> home migrate operations",
>>           "Unit": "hisi_sccl,hha"
>>      },
>>      {
>>           "ConfigCode": "0x4d",
>>           "EventName": "edir-home-migrate",
>> +        "BriefDescription": "Count of the number of HHA E-Dir read 
>> home migrate operations",
>> +        "PublicDescription": "Count of the number of HHA E-Dir read 
>> home migrate operations",
>>           "Unit": "hisi_sccl,hha"
>>      }
>>   ]
>
> .
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-04-17  9:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16  2:02 [PATCH 0/2] perf vendor events arm64: Add some missing content for Hisi hip08 json Junhao He
2025-04-16  2:02 ` [PATCH 1/2] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu Junhao He
2025-04-16 13:17   ` James Clark
2025-04-17  9:05     ` hejunhao
2025-04-16  2:02 ` [PATCH 2/2] MAINTAINERS: Add hisilicon pmu json events under its entry Junhao He
2025-04-16 13:18   ` James Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).