Re: [RFC v3 06/17] perf kwork: Implement perf kwork report

[Yang Jihong <yangjihong1@huawei.com>]

Hello Arnaldo,

On 2022/7/27 22:04, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 27, 2022 at 08:39:33AM +0800, Yang Jihong escreveu:
>> Hello,
>>
>> On 2022/7/27 1:40, Arnaldo Carvalho de Melo wrote:
>>> Em Sat, Jul 09, 2022 at 09:50:22AM +0800, Yang Jihong escreveu:
>>>> +
>>>> +static void report_print_work(struct perf_kwork *kwork,
>>>> +			      struct kwork_work *work)
>>>> +{
>>>> +	int ret = 0;
>>>> +	char kwork_name[PRINT_KWORK_NAME_WIDTH];
>>>> +	char max_runtime_start[32], max_runtime_end[32];
>>>
>>> Committer notes:
>>>
>>> - Add some {} for multiline for/if blocks
>>>
>>> - Return the calculated number of printed bytes in report_print_work,
>>>     otherwise soem compilers will complain that variable isn't used, e.g.:
>>>
>>>      2    92.64 almalinux:9                   : FAIL clang version 13.0.1 (Red Hat 13.0.1-1.el9)
>>>       builtin-kwork.c:1061:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
>>>               int ret = 0;
>>>
>>>
>> OK, I'll fix it in next version.
> 
> your work with these fixups is already at acme/perf/core:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
> 
> Please continue from there. Please let me know if I made some mistake.
> 
> Thanks for working on this!
>
Thanks to these fixups.
OK, I'll send fix patches according to review comments based on this branch.

Regards,
Jihong