From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
vineet.singh@intel.com, perry.taylor@intel.com,
caleb.biggers@intel.com, asaf.yaffe@intel.com,
kshipra.bopardikar@intel.com,
Kan Liang <kan.liang@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
James Clark <james.clark@arm.com>,
John Garry <john.garry@huawei.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf stat: Fix display of grouped aliased events.
Date: Fri, 4 Feb 2022 17:48:20 -0800 [thread overview]
Message-ID: <e3bf95b1-bb9a-91be-1816-59c96c4e2024@linux.intel.com> (raw)
In-Reply-To: <20220205010941.1065469-1-irogers@google.com>
On 2/4/2022 5:09 PM, Ian Rogers wrote:
> An event may have a number of uncore aliases that when added to
> the evlist are consecutive. If there are multiple uncore events
> in a group then parse_events__set_leader_for_uncore_aliase will
> reorder the evlist so that events on the same PMU are
> adjacent. collect_all_aliases assumes that aliases are in blocks
> so that only the first counter is printed and all others are
> marked merged. The reordering for groups breaks the assumption
> and so all counts are printed. This change removes the assumption
> from collect_all_aliases that the events are in blocks and
> instead processes the entire evlist.
Looks good to me.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2022-02-05 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 1:09 [PATCH] perf stat: Fix display of grouped aliased events Ian Rogers
2022-02-05 1:48 ` Andi Kleen [this message]
2022-02-06 11:55 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3bf95b1-bb9a-91be-1816-59c96c4e2024@linux.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=asaf.yaffe@intel.com \
--cc=caleb.biggers@intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kshipra.bopardikar@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=vineet.singh@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).