From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf mem record not getting the mem_load_aux events by default
Date: Wed, 4 Sep 2024 11:20:57 -0400 [thread overview]
Message-ID: <e848ad7b-bc9d-4eca-8918-0dd5a67c347e@linux.intel.com> (raw)
In-Reply-To: <Zthu81fA3kLC2CS2@x1>
On 2024-09-04 10:30 a.m., Arnaldo Carvalho de Melo wrote:
> Hi Kan,
>
> Recently I presented about 'perf mem record' and found that I had use
> 'perf record' directly as 'perf mem record' on a Intel Hybrid system
> wasn't selecting the required aux event:
>
> http://vger.kernel.org/~acme/prez/lsfmm-bpf-2024/#/19
>
> The previous slides show the problem and the one above shows what worked
> for me.
>
> I saw this while trying to fix that:
>
> Author: Kan Liang <kan.liang@linux.intel.com>
> commit abbdd79b786e036e60f01b7907977943ebe7a74d
> Date: Tue Jan 23 10:50:32 2024 -0800
>
> perf mem: Clean up perf_mem_events__name()
>
> Introduce a generic perf_mem_events__name(). Remove the ARCH-specific
> one.
>
> The mem_load events may have a different format. Add ldlat and aux_event
> in the struct perf_mem_event to indicate the format and the extra aux
> event.
>
> Add perf_mem_events_intel_aux[] to support the extra mem_load_aux event.
>
> Rename perf_mem_events__name to perf_pmu__mem_events_name.
>
> --------------------------´
>
> So there are provisions for selecting the right events, but it doesn't
> seem to be working when I tried, can you take a look at what I describe
> on those slides and see what am I doing wrong?
>
If I understand the example in the slides correctly, the issue is that
no mem events from big core are selected when running perf mem record,
rather than wrong mem events are selected.
I don't see an obvious issue. That looks like a regression of the perf
mem record. I will find a Alder Lake or Raptor Lake to take a deep look.
Thanks,
Kan
next prev parent reply other threads:[~2024-09-04 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 14:30 perf mem record not getting the mem_load_aux events by default Arnaldo Carvalho de Melo
2024-09-04 15:20 ` Liang, Kan [this message]
2024-09-04 15:34 ` Arnaldo Carvalho de Melo
2024-09-05 17:23 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e848ad7b-bc9d-4eca-8918-0dd5a67c347e@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).