From: Yunseong Kim <ysk@kzalloc.com>
To: Leo Yan <leo.yan@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Yeoreum Yun <yeoreum.yun@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: arm64: Sync ESR_ELx_EC_* macros in arm64_exception_types.h with esr.h
Date: Sat, 23 Aug 2025 00:01:51 +0900 [thread overview]
Message-ID: <e935e36a-1c5f-4706-830c-95cf6d9e6dc7@kzalloc.com> (raw)
In-Reply-To: <20250821113825.GA745271@e132581.arm.com>
Thank you for the review Leo!
On 8/21/25 8:38 PM, Leo Yan wrote:
> Hi,
>
> On Thu, Aug 14, 2025 at 03:14:53PM +0000, Yunseong Kim wrote:
>> Update perf util arm64_exception_types.h to match the exception class
>> macros defined in tools/arch/arm64/include/asm/esr.h. This ensures
>> consistency between perf tooling and the kernel header definitions for
>> ESR_ELx_EC_* values.
>>
>> Signed-off-by: Yunseong Kim <ysk@kzalloc.com>
>
> Thanks for working on this.
>
> This patch still misses couple macros, please see below.
I nearly missed that. Appreciate your checking.
>> ---
>> tools/perf/arch/arm64/util/arm64_exception_types.h | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/perf/arch/arm64/util/arm64_exception_types.h b/tools/perf/arch/arm64/util/arm64_exception_types.h
>> index 27c981ebe401..29931bf19062 100644
>> --- a/tools/perf/arch/arm64/util/arm64_exception_types.h
>> +++ b/tools/perf/arch/arm64/util/arm64_exception_types.h
>> @@ -33,7 +33,7 @@
>> #define ESR_ELx_EC_PAC (0x09) /* EL2 and above */
>> /* Unallocated EC: 0x0A - 0x0B */
>
> #define ESR_ELx_EC_OTHER (0x0A)
>
>> #define ESR_ELx_EC_CP14_64 (0x0C)
>> -/* Unallocated EC: 0x0d */
>> +#define ESR_ELx_EC_BTI (0x0D)
>> #define ESR_ELx_EC_ILL (0x0E)
>> /* Unallocated EC: 0x0F - 0x10 */
>> #define ESR_ELx_EC_SVC32 (0x11)
>> @@ -46,7 +46,10 @@
>> #define ESR_ELx_EC_SYS64 (0x18)
>> #define ESR_ELx_EC_SVE (0x19)
>> #define ESR_ELx_EC_ERET (0x1a) /* EL2 only */
>> -/* Unallocated EC: 0x1b - 0x1E */
>> +/* Unallocated EC: 0x1B */
>> +#define ESR_ELx_EC_FPAC (0x1C) /* EL1 and above */
>> +#define ESR_ELx_EC_SME (0x1D)
>> +/* Unallocated EC: 0x1E */
>> #define ESR_ELx_EC_IMP_DEF (0x1f) /* EL3 only */
>> #define ESR_ELx_EC_IABT_LOW (0x20)
>> #define ESR_ELx_EC_IABT_CUR (0x21)
>> @@ -55,7 +58,7 @@
>> #define ESR_ELx_EC_DABT_LOW (0x24)
>> #define ESR_ELx_EC_DABT_CUR (0x25)
>> #define ESR_ELx_EC_SP_ALIGN (0x26)
>> -/* Unallocated EC: 0x27 */
>> +#define ESR_ELx_EC_MOPS (0x27)
>> #define ESR_ELx_EC_FP_EXC32 (0x28)
>> /* Unallocated EC: 0x29 - 0x2B */
>> #define ESR_ELx_EC_FP_EXC64 (0x2C)
>
> #define ESR_ELx_EC_GCS (0x2D)
>
> Thanks,
> Leo
>
>> --
>> 2.50.0
>>
I’ve sent out patch v2, Thanks everyone!
Best regards,
Yunseong Kim
prev parent reply other threads:[~2025-08-22 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 15:14 [PATCH] perf: arm64: Sync ESR_ELx_EC_* macros in arm64_exception_types.h with esr.h Yunseong Kim
2025-08-19 10:15 ` Will Deacon
2025-08-21 11:38 ` Leo Yan
2025-08-22 15:01 ` Yunseong Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e935e36a-1c5f-4706-830c-95cf6d9e6dc7@kzalloc.com \
--to=ysk@kzalloc.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox