* [PATCH v1] perf test: Fix "PMU event table sanity" for NO_JEVENTS=1
@ 2023-03-08 0:27 Ian Rogers
2023-03-08 9:58 ` John Garry
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2023-03-08 0:27 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Kajol Jain, John Garry, linux-perf-users,
linux-kernel
A table was renamed and needed to be renamed in the empty case.
Fixes: 62774db2a05d ("perf jevents: Generate metrics and events as separate tables")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/pmu-events/empty-pmu-events.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/pmu-events/empty-pmu-events.c b/tools/perf/pmu-events/empty-pmu-events.c
index a938b74cf487..e74defb5284f 100644
--- a/tools/perf/pmu-events/empty-pmu-events.c
+++ b/tools/perf/pmu-events/empty-pmu-events.c
@@ -227,7 +227,7 @@ static const struct pmu_events_map pmu_events_map[] = {
},
};
-static const struct pmu_event pme_test_soc_sys[] = {
+static const struct pmu_event pmu_events__test_soc_sys[] = {
{
.name = "sys_ddr_pmu.write_cycles",
.event = "event=0x2b",
@@ -258,8 +258,8 @@ struct pmu_sys_events {
static const struct pmu_sys_events pmu_sys_event_tables[] = {
{
- .table = { pme_test_soc_sys },
- .name = "pme_test_soc_sys",
+ .table = { pmu_events__test_soc_sys },
+ .name = "pmu_events__test_soc_sys",
},
{
.table = { 0 }
--
2.40.0.rc0.216.gc4246ad0f0-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] perf test: Fix "PMU event table sanity" for NO_JEVENTS=1
2023-03-08 0:27 [PATCH v1] perf test: Fix "PMU event table sanity" for NO_JEVENTS=1 Ian Rogers
@ 2023-03-08 9:58 ` John Garry
2023-03-14 11:43 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: John Garry @ 2023-03-08 9:58 UTC (permalink / raw)
To: Ian Rogers, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Kajol Jain, linux-perf-users, linux-kernel
On 08/03/2023 00:27, Ian Rogers wrote:
> A table was renamed and needed to be renamed in the empty case.
>
> Fixes: 62774db2a05d ("perf jevents: Generate metrics and events as separate tables")
This looks ok, so:
Reviewed-by: John Garry <john.g.garry@oracle.com>
But a comment, below.
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/pmu-events/empty-pmu-events.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/pmu-events/empty-pmu-events.c b/tools/perf/pmu-events/empty-pmu-events.c
> index a938b74cf487..e74defb5284f 100644
> --- a/tools/perf/pmu-events/empty-pmu-events.c
> +++ b/tools/perf/pmu-events/empty-pmu-events.c
> @@ -227,7 +227,7 @@ static const struct pmu_events_map pmu_events_map[] = {
> },
> };
>
> -static const struct pmu_event pme_test_soc_sys[] = {
> +static const struct pmu_event pmu_events__test_soc_sys[] = {
Would it make sense or even possible to put these table names in macros
in a common header?
Thanks,
John
> {
> .name = "sys_ddr_pmu.write_cycles",
> .event = "event=0x2b",
> @@ -258,8 +258,8 @@ struct pmu_sys_events {
>
> static const struct pmu_sys_events pmu_sys_event_tables[] = {
> {
> - .table = { pme_test_soc_sys },
> - .name = "pme_test_soc_sys",
> + .table = { pmu_events__test_soc_sys },
> + .name = "pmu_events__test_soc_sys",
> },
> {
> .table = { 0 }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] perf test: Fix "PMU event table sanity" for NO_JEVENTS=1
2023-03-08 9:58 ` John Garry
@ 2023-03-14 11:43 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-03-14 11:43 UTC (permalink / raw)
To: John Garry
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Kajol Jain,
linux-perf-users, linux-kernel
Em Wed, Mar 08, 2023 at 09:58:16AM +0000, John Garry escreveu:
> On 08/03/2023 00:27, Ian Rogers wrote:
> > A table was renamed and needed to be renamed in the empty case.
> >
> > Fixes: 62774db2a05d ("perf jevents: Generate metrics and events as separate tables")
>
> This looks ok, so:
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
Thanks, applied.
- Arnaldo
> But a comment, below.
>
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/pmu-events/empty-pmu-events.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/perf/pmu-events/empty-pmu-events.c b/tools/perf/pmu-events/empty-pmu-events.c
> > index a938b74cf487..e74defb5284f 100644
> > --- a/tools/perf/pmu-events/empty-pmu-events.c
> > +++ b/tools/perf/pmu-events/empty-pmu-events.c
> > @@ -227,7 +227,7 @@ static const struct pmu_events_map pmu_events_map[] = {
> > },
> > };
> > -static const struct pmu_event pme_test_soc_sys[] = {
> > +static const struct pmu_event pmu_events__test_soc_sys[] = {
>
> Would it make sense or even possible to put these table names in macros in a
> common header?
>
> Thanks,
> John
>
> > {
> > .name = "sys_ddr_pmu.write_cycles",
> > .event = "event=0x2b",
> > @@ -258,8 +258,8 @@ struct pmu_sys_events {
> > static const struct pmu_sys_events pmu_sys_event_tables[] = {
> > {
> > - .table = { pme_test_soc_sys },
> > - .name = "pme_test_soc_sys",
> > + .table = { pmu_events__test_soc_sys },
> > + .name = "pmu_events__test_soc_sys",
> > },
> > {
> > .table = { 0 }
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-14 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-08 0:27 [PATCH v1] perf test: Fix "PMU event table sanity" for NO_JEVENTS=1 Ian Rogers
2023-03-08 9:58 ` John Garry
2023-03-14 11:43 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).