From: Li Huafei <lihuafei1@huawei.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: <linux@armlinux.org.uk>, <rmk+kernel@armlinux.org.uk>,
<ardb@kernel.org>, <will@kernel.org>, <mark.rutland@arm.com>,
<broonie@kernel.org>, <peterz@infradead.org>, <mingo@redhat.com>,
<acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <namhyung@kernel.org>, <arnd@arndb.de>,
<rostedt@goodmis.org>, <nick.hawkins@hpe.com>, <john@phrozen.org>,
<mhiramat@kernel.org>, <ast@kernel.org>, <linyujun809@huawei.com>,
<ndesaulniers@google.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK
Date: Wed, 27 Jul 2022 14:29:29 +0800 [thread overview]
Message-ID: <ecc9376b-694b-e42c-977c-813be0a76792@huawei.com> (raw)
In-Reply-To: <CACRpkdZVxyCsENJQ_-KZBMHjVrYCHzFG2UdCAe=mt_5Ts8_RFw@mail.gmail.com>
Hi Linus,
On 2022/7/18 17:12, Linus Walleij wrote:
> On Tue, Jul 12, 2022 at 4:19 AM Li Huafei <lihuafei1@huawei.com> wrote:
>
>> This patch converts ARM stacktrace to the generic ARCH_STACKWALK
>> implemented by commit 214d8ca6ee85 ("stacktrace: Provide common
>> infrastructure").
>>
>> Signed-off-by: Li Huafei <lihuafei1@huawei.com>
>
> Looks good to me:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> What I want to know is if this commit will avoid the problem mentioned
> in review of commit 3? I.e. the generic stackwalk code will make sure we are
> not running the task on another CPU, so that is why we could remove
> that check?
>
In v3, I removed patch 3 of v1 and kept that check, see
https://lore.kernel.org/lkml/20220727040022.139387-1-lihuafei1@huawei.com/
Given this change, I did not add your reviewed-by to patch 4 of v3. If
you think patch 4 of v3 is still ok, please do let me know. Thank you
very much!
Thanks,
Huafei
> Yours,
> Linus Walleij
> .
>
prev parent reply other threads:[~2022-07-27 6:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 2:15 [PATCH 0/5] ARM: Convert to ARCH_STACKWALK Li Huafei
2022-07-12 2:15 ` [PATCH 1/5] ARM: stacktrace: Skip frame pointer boundary check for call_with_stack() Li Huafei
2022-07-18 8:57 ` Linus Walleij
2022-07-26 8:10 ` Li Huafei
2022-07-12 2:15 ` [PATCH 2/5] ARM: stacktrace: Avoid duplicate saving of exception PC value Li Huafei
2022-07-18 9:01 ` Linus Walleij
2022-07-26 9:10 ` Li Huafei
2022-07-26 10:22 ` Russell King (Oracle)
2022-07-26 12:21 ` Li Huafei
2022-07-12 2:15 ` [PATCH 3/5] ARM: stacktrace: Allow stack trace saving for non-current tasks Li Huafei
2022-07-18 9:07 ` Linus Walleij
2022-07-26 9:12 ` Li Huafei
2022-07-26 9:49 ` Russell King (Oracle)
2022-07-26 12:08 ` Li Huafei
2022-07-12 2:15 ` [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code Li Huafei
2022-07-12 13:34 ` Mark Brown
2022-07-13 11:21 ` Li Huafei
2022-07-18 9:09 ` Linus Walleij
2022-07-26 9:19 ` Li Huafei
2022-07-12 2:15 ` [PATCH 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK Li Huafei
2022-07-18 9:12 ` Linus Walleij
2022-07-26 9:15 ` Li Huafei
2022-07-27 6:29 ` Li Huafei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecc9376b-694b-e42c-977c-813be0a76792@huawei.com \
--to=lihuafei1@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=broonie@kernel.org \
--cc=john@phrozen.org \
--cc=jolsa@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linyujun809@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nick.hawkins@hpe.com \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).