From: Yunseong Kim <yskelg@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: kan.liang@linux.intel.com, Yang Jihong <yangjihong1@huawei.com>,
Ze Gao <zegao2021@gmail.com>, Leo Yan <leo.yan@linux.dev>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Austin Kim <austindh.kim@gmail.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
MichelleJin <shjy180909@gmail.com>
Subject: Re: [PATCH] perf unwind-libunwind: Add malloc() failure handling
Date: Thu, 27 Jun 2024 00:47:47 +0900 [thread overview]
Message-ID: <ee434711-e4b1-47cf-a47a-6ba15ec6241d@gmail.com> (raw)
In-Reply-To: <171937445590.2860437.11253278806338067490.b4-ty@kernel.org>
Hi Namhyung,
On 6/26/24 1:01 오후, Namhyung Kim wrote:
> On Thu, 20 Jun 2024 05:42:12 +0900, yskelg@gmail.com wrote:
>> This patch resolve following warning.
>>
>> tools/perf/util/evsel.c:1620:9: error: result of comparison of constant
>> -1 with expression of type 'char' is always false
>> -Werror,-Wtautological-constant-out-of-range-compare
>> 1620 | if (c == -1)
>> | ~ ^ ~~
>>
>> [...]
> Applied to perf-tools-next, thanks!
Thank you!
>> Add malloc() failure handling in unread_unwind_spec_debug_frame().
>> This make caller find_proc_info() works well when the allocation failure.
>>
>>
>
> Applied to perf-tools-next, thanks!
>
> Best regards,
> Namhyung
Thank you for applying my patch set.
I've been looking up the feedback you provided earlier and analyzing it
further.
Next time, I will strive to send a more meaningful patch set.
Warm regards,
Yunseong Kim
prev parent reply other threads:[~2024-06-26 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 20:42 [PATCH] perf unwind-libunwind: Add malloc() failure handling yskelg
2024-06-26 4:01 ` Namhyung Kim
2024-06-26 15:47 ` Yunseong Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee434711-e4b1-47cf-a47a-6ba15ec6241d@gmail.com \
--to=yskelg@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=austindh.kim@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=shjy180909@gmail.com \
--cc=yangjihong1@huawei.com \
--cc=zegao2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).