From: Yicong Yang <yangyicong@huawei.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: <gregkh@linuxfoundation.org>,
<alexander.shishkin@linux.intel.com>, <leo.yan@linaro.org>,
<james.clark@arm.com>, <will@kernel.org>, <robin.murphy@arm.com>,
<acme@kernel.org>, <peterz@infradead.org>, <corbet@lwn.net>,
<mathieu.poirier@linaro.org>, <mark.rutland@arm.com>,
<jonathan.cameron@huawei.com>, <john.garry@huawei.com>,
<helgaas@kernel.org>, <lorenzo.pieralisi@arm.com>,
<suzuki.poulose@arm.com>, <joro@8bytes.org>,
<shameerali.kolothum.thodi@huawei.com>, <mingo@redhat.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pci@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
<iommu@lists.linux-foundation.org>, <iommu@lists.linux.dev>,
<linux-doc@vger.kernel.org>, <prime.zeng@huawei.com>,
<liuqi115@huawei.com>, <zhangshaokun@hisilicon.com>,
<linuxarm@huawei.com>, Yicong Yang <yangyicong@hisilicon.com>
Subject: Re: [PATCH v10 7/8] docs: trace: Add HiSilicon PTT device driver documentation
Date: Mon, 18 Jul 2022 15:10:22 +0800 [thread overview]
Message-ID: <f0dc5cb8-ec3b-eb8f-98e3-4a6301e8be06@huawei.com> (raw)
In-Reply-To: <YtEgoZveaZJ3a7+4@debian.me>
On 2022/7/15 16:09, Bagas Sanjaya wrote:
> On Thu, Jul 14, 2022 at 05:27:09PM +0800, Yicong Yang wrote:
>> +1. Tx path QoS control
>> +------------------------
>> +
> <snip>
>> +2. Tx path buffer control
>> +-------------------------
>> +
>
> Shouldn't Tx in the headings above be lowercase (tx)?
Tx is used to keep consistence with other places.
>
>> +1. filter
>> +---------
> <snip>
>> +2. type
>> +-------
> <snip>
>> +3. direction
>> +------------
> <snip>
>> +4. format
>> +--------------
> <snip>
>> +5. memory management
>> +--------------------
> <snip>
>> +6. decoding
>> +-----------
>
> I think these headings above should use title case instead.
ok.
>
> Anyway, the documentation (htmldocs) builds successfully without new
> warnings.
>
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
>
Thanks.
next prev parent reply other threads:[~2022-07-18 7:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 9:27 [PATCH v10 0/8] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang
2022-07-14 9:27 ` [PATCH v10 1/8] iommu/arm-smmu-v3: Make default domain type of HiSilicon PTT device to identity Yicong Yang
2022-07-14 9:27 ` [PATCH v10 2/8] hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device Yicong Yang
2022-07-14 9:27 ` [PATCH v10 3/8] hwtracing: hisi_ptt: Add tune " Yicong Yang
2022-07-14 9:27 ` [PATCH v10 4/8] perf tool: arm: Refactor event list iteration in auxtrace_record__init() Yicong Yang
2022-07-14 9:27 ` [PATCH v10 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver Yicong Yang
2022-07-14 9:27 ` [PATCH v10 6/8] perf tool: Add support for parsing HiSilicon PCIe Trace packet Yicong Yang
2022-07-14 9:27 ` [PATCH v10 7/8] docs: trace: Add HiSilicon PTT device driver documentation Yicong Yang
2022-07-15 8:09 ` Bagas Sanjaya
2022-07-18 7:10 ` Yicong Yang [this message]
2022-07-14 9:27 ` [PATCH v10 8/8] MAINTAINERS: Add maintainer for HiSilicon PTT driver Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0dc5cb8-ec3b-eb8f-98e3-4a6301e8be06@huawei.com \
--to=yangyicong@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=joro@8bytes.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).