From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C07C433FE for ; Mon, 14 Nov 2022 11:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbiKNLSE (ORCPT ); Mon, 14 Nov 2022 06:18:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236842AbiKNLRI (ORCPT ); Mon, 14 Nov 2022 06:17:08 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8359D21E2C; Mon, 14 Nov 2022 03:14:31 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9093E23A; Mon, 14 Nov 2022 03:14:37 -0800 (PST) Received: from [10.57.70.83] (unknown [10.57.70.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF4F93F73D; Mon, 14 Nov 2022 03:14:28 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 11:14:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 12/12] perf test: Replace data symbol test workload with datasym Content-Language: en-US To: Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa Cc: Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Leo Yan , German Gomez , Zhengjun Xing , Athira Jajeev References: <20221110181920.84900-1-namhyung@kernel.org> <20221110181920.84900-13-namhyung@kernel.org> From: James Clark In-Reply-To: <20221110181920.84900-13-namhyung@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 10/11/2022 18:19, Namhyung Kim wrote: > So that it can get rid of requirement of a compiler. > > $ sudo ./perf test -v 109 > 109: Test data symbol : > --- start --- > test child forked, pid 844526 > Recording workload... > [ perf record: Woken up 2 times to write data ] > [ perf record: Captured and wrote 0.354 MB /tmp/__perf_test.perf.data.GFeZO (4847 samples) ] > Cleaning up files... > test child finished with 0 > ---- end ---- > Test data symbol: Ok > > Cc: Leo Yan > Signed-off-by: Namhyung Kim > --- > tools/perf/tests/shell/test_data_symbol.sh | 29 +--------------------- > 1 file changed, 1 insertion(+), 28 deletions(-) > Tested-by: James Clark > diff --git a/tools/perf/tests/shell/test_data_symbol.sh b/tools/perf/tests/shell/test_data_symbol.sh > index cd6eb54d235d..d871e6c743ef 100755 > --- a/tools/perf/tests/shell/test_data_symbol.sh > +++ b/tools/perf/tests/shell/test_data_symbol.sh > @@ -11,13 +11,7 @@ skip_if_no_mem_event() { > > skip_if_no_mem_event || exit 2 > > -# skip if there's no compiler > -if ! [ -x "$(command -v cc)" ]; then > - echo "skip: no compiler, install gcc" > - exit 2 > -fi > - > -TEST_PROGRAM=$(mktemp /tmp/__perf_test.program.XXXXX) > +TEST_PROGRAM="perf test -w datasym" > PERF_DATA=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > > check_result() { > @@ -45,31 +39,10 @@ cleanup_files() > { > echo "Cleaning up files..." > rm -f ${PERF_DATA} > - rm -f ${TEST_PROGRAM} > } > > trap cleanup_files exit term int > > -# compile test program > -echo "Compiling test program..." > -cat << EOF | cc -o ${TEST_PROGRAM} -x c - > -typedef struct _buf { > - char data1; > - char reserved[55]; > - char data2; > -} buf __attribute__((aligned(64))); > - > -static buf buf1; > - > -int main(void) { > - for (;;) { > - buf1.data1++; > - buf1.data2 += buf1.data1; > - } > - return 0; > -} > -EOF > - > echo "Recording workload..." > > # perf mem/c2c internally uses IBS PMU on AMD CPU which doesn't support