From: Markus Elfring <Markus.Elfring@web.de>
To: Ian Rogers <irogers@google.com>, linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
James Clark <james.clark@linaro.org>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Thomas Falcon <thomas.falcon@intel.com>,
Weilin Wang <weilin.wang@intel.com>
Subject: Re: [PATCH 1/2] perf topdown: Use attribute to see an event is a topdown metic or slots
Date: Fri, 18 Jul 2025 21:13:23 +0200 [thread overview]
Message-ID: <f39dda96-9e4e-4f33-a4fb-a97c375d281e@web.de> (raw)
In-Reply-To: <20250718071734.1444891-1-irogers@google.com>
> The string comparisons were overly broad and could fire for the
> incorrect PMU and events. Switch to using the config in the attribute
…
How do you think about to refer to a “metric” in the summary phrase?
Will a cover letter become helpful for such a patch series?
Regards,
Markus
prev parent reply other threads:[~2025-07-18 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 7:17 [PATCH v1 1/2] perf topdown: Use attribute to see an event is a topdown metic or slots Ian Rogers
2025-07-18 7:17 ` [PATCH v1 2/2] perf parse-events: Fix missing slots for Intel topdown metric events Ian Rogers
2025-07-18 8:51 ` [PATCH v1 1/2] perf topdown: Use attribute to see an event is a topdown metic or slots Mi, Dapeng
2025-07-18 13:15 ` Ian Rogers
2025-07-18 19:13 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f39dda96-9e4e-4f33-a4fb-a97c375d281e@web.de \
--to=markus.elfring@web.de \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=thomas.falcon@intel.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).