From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>, Xu Yang <xu.yang_2@nxp.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: perf: fsl-imx-ddr: Add compatible string for i.MX8QM, i.MX8QXP and i.MX8DXL
Date: Fri, 24 Oct 2025 15:03:10 +0200 [thread overview]
Message-ID: <fbef6d02-74e8-4550-81af-afe7ac4c989b@kernel.org> (raw)
In-Reply-To: <20251023-qm_dts-v1-1-9830d6a45939@nxp.com>
On 23/10/2025 20:56, Frank Li wrote:
> Add compatible string fsl,imx8qm-ddr-pmu, fsl,imx8qxp-ddr-pmu and
> fsl,imx8dxl-db-pmu (for data bus fabric).
>
> Add clocks and clock-names for fsl,imx8dxl-db-pmu and keep the same
> restriction for existing compatible strings.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/perf/fsl-imx-ddr.yaml | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> index d2e578d6b83b8847c7a0ca9d5aeb208a90e2fa6a..13eb13a79e2100ae1d747ddf6fc4db5b470112a8 100644
> --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> @@ -14,6 +14,7 @@ properties:
> oneOf:
> - enum:
> - fsl,imx8-ddr-pmu
> + - fsl,imx8dxl-db-pmu
> - fsl,imx8m-ddr-pmu
> - fsl,imx8mq-ddr-pmu
> - fsl,imx8mm-ddr-pmu
> @@ -29,6 +30,8 @@ properties:
> - const: fsl,imx8m-ddr-pmu
> - items:
> - const: fsl,imx8dxl-ddr-pmu
> + - const: fsl,imx8qm-ddr-pmu
> + - const: fsl,imx8qxp-ddr-pmu
I don't understand the need for this change, not explained in commit
msg. Why do you change 8dxl-ddr?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-24 13:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 18:56 [PATCH 0/6] perf/imx_ddr: Add i.MX8QM and pmu in DB (system interconnects) Frank Li
2025-10-23 18:56 ` [PATCH 1/6] dt-bindings: perf: fsl-imx-ddr: Add compatible string for i.MX8QM, i.MX8QXP and i.MX8DXL Frank Li
2025-10-24 13:03 ` Krzysztof Kozlowski [this message]
2025-10-24 13:19 ` Frank Li
2025-10-24 15:50 ` Krzysztof Kozlowski
2025-10-23 18:56 ` [PATCH 2/6] perf/imx_ddr: Move ida_alloc() from ddr_perf_init() to ddr_perf_probe() Frank Li
2025-10-23 18:56 ` [PATCH 3/6] perf/imx_ddr: Get and enable optional clks Frank Li
2025-10-23 18:56 ` [PATCH 4/6] perf/imx_ddr: Add support for PMU in DB (system interconnects) Frank Li
2025-10-23 18:56 ` [PATCH 5/6] arm64: dts: imx8qm: add ddr perf device node Frank Li
2025-10-23 18:56 ` [PATCH 6/6] arm64: dts: imx8dxl-ss-ddr: Add DB (system interconnects) pmu support for i.MX8DXL Frank Li
2025-10-24 12:17 ` [PATCH 0/6] perf/imx_ddr: Add i.MX8QM and pmu in DB (system interconnects) Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbef6d02-74e8-4550-81af-afe7ac4c989b@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).