Re: [PATCH] tools headers: Sync x86 cpufeatures and arm64 cputype headers

Re: [PATCH] tools headers: Sync x86 cpufeatures and arm64 cputype headers

[Leo Yan]

Hi Shivank,

[ + James, perf-user ML ]

On Mon, Sep 29, 2025 at 06:16:45AM +0000, Shivank Garg wrote:
> To pick up the changes in this cset:
> 
> commit 2f8f173413f1 ("x86/vmscape: Add conditional IBPB mitigation")
> commit a508cec6e521 ("x86/vmscape: Enumerate VMSCAPE bug")
> commit c8c2647e69be ("arm64: Make  _midr_in_range_list() an exported function")
> commit e3121298c7fc ("arm64: Modify _midr_range() functions to read MIDR/REVIDR internally")
> 
> This addresses these perf build warnings:
> tools/perf$ ./check-headers.sh
> Warning: Kernel ABI header differences:
>   diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures
>   diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h

Please drop arm64 related syncing, otherwise, it will break perf
building.

At the meantime, James is working on refactoring cpu type definitions
for Arm64, we expect to avoid syncing cputype.h.

Thanks,
Leo

Re: [PATCH] tools headers: Sync x86 cpufeatures and arm64 cputype headers

[Garg, Shivank]

On 9/29/2025 1:57 PM, Leo Yan wrote:
> Hi Shivank,
> 
> [ + James, perf-user ML ]
> 
> On Mon, Sep 29, 2025 at 06:16:45AM +0000, Shivank Garg wrote:
>> To pick up the changes in this cset:
>>
>> commit 2f8f173413f1 ("x86/vmscape: Add conditional IBPB mitigation")
>> commit a508cec6e521 ("x86/vmscape: Enumerate VMSCAPE bug")
>> commit c8c2647e69be ("arm64: Make  _midr_in_range_list() an exported function")
>> commit e3121298c7fc ("arm64: Modify _midr_range() functions to read MIDR/REVIDR internally")
>>
>> This addresses these perf build warnings:
>> tools/perf$ ./check-headers.sh
>> Warning: Kernel ABI header differences:
>>   diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures
>>   diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
> 
> Please drop arm64 related syncing, otherwise, it will break perf
> building.

Sure, I'll send V2 without arm64 sync.

Thanks,
Shivank
> 
> At the meantime, James is working on refactoring cpu type definitions
> for Arm64, we expect to avoid syncing cputype.h.
> 
> Thanks,
> Leo

Re: [PATCH] tools headers: Sync x86 cpufeatures and arm64 cputype headers

[Garg, Shivank]

On 9/29/2025 2:47 PM, Garg, Shivank wrote:
> 
> 
> On 9/29/2025 1:57 PM, Leo Yan wrote:
>> Hi Shivank,
>>
>> [ + James, perf-user ML ]
>>
>> On Mon, Sep 29, 2025 at 06:16:45AM +0000, Shivank Garg wrote:
>>> To pick up the changes in this cset:
>>>
>>> commit 2f8f173413f1 ("x86/vmscape: Add conditional IBPB mitigation")
>>> commit a508cec6e521 ("x86/vmscape: Enumerate VMSCAPE bug")
>>> commit c8c2647e69be ("arm64: Make  _midr_in_range_list() an exported function")
>>> commit e3121298c7fc ("arm64: Modify _midr_range() functions to read MIDR/REVIDR internally")
>>>
>>> This addresses these perf build warnings:
>>> tools/perf$ ./check-headers.sh
>>> Warning: Kernel ABI header differences:
>>>   diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures
>>>   diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
>>
>> Please drop arm64 related syncing, otherwise, it will break perf
>> building.
> 
> Sure, I'll send V2 without arm64 sync.
> 
> Thanks,
> Shivank
>>
>> At the meantime, James is working on refactoring cpu type definitions
>> for Arm64, we expect to avoid syncing cputype.h.
>>
>> Thanks,
>> Leo
> 

tools/perf$ make
  BUILD:   Doing 'make -j128' parallel build
Warning: Kernel ABI header differences:
  diff -u tools/include/linux/cfi_types.h include/linux/cfi_types.h
  diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h
  diff -u tools/include/asm-generic/bitops/__fls.h include/asm-generic/bitops/__fls.h
  diff -u tools/include/asm-generic/bitops/fls.h include/asm-generic/bitops/fls.h
  diff -u tools/include/asm-generic/bitops/fls64.h include/asm-generic/bitops/fls64.h
  diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
  diff -u tools/perf/trace/beauty/include/uapi/linux/fcntl.h include/uapi/linux/fcntl.h
  diff -u tools/perf/trace/beauty/include/uapi/linux/fs.h include/uapi/linux/fs.h

There are a lot of new ABI differences today, so I think it’s best to sync after the merge window?

Thanks,
Shivank