From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F134719D88D for ; Tue, 1 Oct 2024 12:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727787132; cv=none; b=CcS+D0GPUmwcF7i85DyjnLEQ5cN3ieglxxmPqSd+c/xp9dqqd211+g+BUqBzz8SASitL45Fxn3WZlfRu8mOZsrAOveDl4kBfftdmNnWmhijX//tDdegXSyGfRcdQ4xm58H0OiRX1Y3YaOBuH3XNEkz7pPzqV1fgPpIe42AHYJ/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727787132; c=relaxed/simple; bh=JlkaSiAgN3xTEzEqDG1SQTaRVlE7Hw2fHY1BzOUdCVo=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=GsONcbXPEHHRb1C7zvfYSWv3Wf8Nod6Ir4JFxjPsAO7oyfsk9IVq+qzoriNfdq9c5A4+vcqwF99aHFKdVGjlhlbtt88146R2ADeNGii/3GlUOwHm3V6ILDjKs7+W7E+h/wTGwtCYO2U1WCPlrufZ5YggeP2LSg3XpSA175XuUoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UA3DaIP8; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UA3DaIP8" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42cae4eb026so52898115e9.0 for ; Tue, 01 Oct 2024 05:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727787128; x=1728391928; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=EUq5fZGbbPn3513u3fVju2MeIm4zQOr1qxH8ZL4URXA=; b=UA3DaIP8TK9ZYdUk58MHTJt/GZINYA3YPe8cGdRpE+Tn3I2j8lYyhPcbO6oP8vkQ4S mk73HKcRYY+vn5FHecs/K1wtDCY/R4xwIjXPRS8rev+FM6Zijsp1rMVjlLy+yl/0UTLO OTUoPZCdUrQySZoU9P77bd+qrFozDYkXKneoupLhnIlMQui5jQwFVlHrfctY1rdn8QBi hgOp1/kDUv2xAmeNmYgmrv42qDteTP8Eu7unmn074cMurm3sMUpeDpubwPC+VFfhXDns jN5M2n9yWe9w0YznrqI7rcvM/U5kRP+89Mm8jP2WqWqKI1YElnZfshVR4nkgtBvD7f5g SFnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727787128; x=1728391928; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EUq5fZGbbPn3513u3fVju2MeIm4zQOr1qxH8ZL4URXA=; b=Es9lLha6ZdrBwFvTWiuEqK1afVKXNa25SgUkPpMJx44UgVdds0nTNEf2EN009/w1bQ vLOwWxebDXQy5DReJYyD/XVdwgI4KzWjI3UJ2+1YsiKN87EaUYoA2oWIyd/T/oAgzt1j OFyzJLTtGP0/AEWoUF7wpB1Ia5O5Nkh/htovPsYNqeCBsIKx+RrHe1K53t5lfCIICe90 as0RTM1maGHQwFWFqvemJaKKinxxNMaKOPLoqOByBO/m1UIa4oWpkBdRLkxycSxqNJyD UHZbnAq50mfGEfaY2lKwfvsRTBhbCb9CXlR6TN+LPK55H+m/ekqnTrp0rvGubzEaHD0U L5QQ== X-Forwarded-Encrypted: i=1; AJvYcCXTr4KQSz/1LnE83WUG/PcN4bLZIkj7pw/QDKEWPwZBJ7y5dr3rD6k97S/bISM+YWpdG/yGoVnF6sVgm+qfqNO3@vger.kernel.org X-Gm-Message-State: AOJu0YygyjQtFLPbtGvm9CM97kuHhHOkv+fLjeKLhE//jDPf6kyhqfDj LhRutVHZi9ciIdCPcui9lswNcCxYtT8r/1Q880aVAsnfNO5zXHMj/jWnwblBy8E= X-Google-Smtp-Source: AGHT+IFR6HNupC1HeuHYSnieXwS/ntW/kPUt2iZipAdegZkpxM1sTKBmJMBScL6eBRM3w0y5ZoyCYg== X-Received: by 2002:a05:600c:45cb:b0:42c:b905:2bf9 with SMTP id 5b1f17b1804b1-42f5844aaf2mr130829325e9.16.1727787128252; Tue, 01 Oct 2024 05:52:08 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f57e13a28sm134533505e9.29.2024.10.01.05.52.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 05:52:07 -0700 (PDT) Message-ID: Date: Tue, 1 Oct 2024 13:52:06 +0100 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] perf python: Remove python 2 scripting support To: Ian Rogers , Namhyung Kim References: <20240918225418.166717-1-irogers@google.com> <20240918225418.166717-2-irogers@google.com> Content-Language: en-US Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Xu Yang , Andi Kleen , Zixian Cai , Paran Lee , Ben Gainey , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org From: James Clark In-Reply-To: <20240918225418.166717-2-irogers@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/09/2024 11:54 pm, Ian Rogers wrote: > Python2 was deprecated 4 years ago, remove support and workarounds. > > Signed-off-by: Ian Rogers > --- > .../scripts/python/Perf-Trace-Util/Context.c | 18 ----- > tools/perf/util/python.c | 73 +++---------------- > .../scripting-engines/trace-event-python.c | 63 +--------------- > 3 files changed, 15 insertions(+), 139 deletions(-) > > diff --git a/tools/perf/scripts/python/Perf-Trace-Util/Context.c b/tools/perf/scripts/python/Perf-Trace-Util/Context.c > index 3954bd1587ce..6d1c6be1d918 100644 > --- a/tools/perf/scripts/python/Perf-Trace-Util/Context.c > +++ b/tools/perf/scripts/python/Perf-Trace-Util/Context.c > @@ -23,16 +23,6 @@ > #include "../../../util/srcline.h" > #include "../../../util/srccode.h" > > -#if PY_MAJOR_VERSION < 3 > -#define _PyCapsule_GetPointer(arg1, arg2) \ > - PyCObject_AsVoidPtr(arg1) > -#define _PyBytes_FromStringAndSize(arg1, arg2) \ > - PyString_FromStringAndSize((arg1), (arg2)) > -#define _PyUnicode_AsUTF8(arg) \ > - PyString_AsString(arg) > - If we know the workarounds were required should we add an error to prevent hard to debug build issues? #if PY_MAJOR_VERSION < 3 #error "Python 2 not supported" #endif Or maybe something in the top level makefile?