Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sandipan Das" <sandipan.das@amd.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/3] perf vendor events amd: Add Zen 6 data fabric events
Date: Mon, 12 Oct 2026 07:59:06 +0000	[thread overview]
Message-ID: <sashiko-outbox-167816@kernel.org> (raw)
In-Reply-To: <9ae74ab1337b627f06f1cfb9e5c91c6e42ac6284.1791791463.git.sandipan.das@amd.com>

> Add Zen 6 data fabric events sourced from Section 8.1 titled "Fabric
> Performance Monitor Counter (PMC) Events" of the Processor Programming
> Reference (PPR) for AMD Family 1Ah Model 51h Revision B0 processors,
> available at the link below.
> 
> The events are primarily meant to monitor the flow of data at various
> links and interfaces within the Data Fabric.
> 
> Unlike previous generations, the events do not set "PerPkg". On Zen 6
> processors, a socket can have up to two IODs, each with its own Data
> Fabric instance. Perf de-duplicates "PerPkg" counts by socket and die,
> but the two IODs do not show up as separate domains in the topology
> information. Setting "PerPkg" would therefore drop the counts from the
> second IOD. The trade-off is that counts are no longer de-duplicated if
> a CPU list with multiple CPUs from the same IOD is specified with "-C".
> 
> Link: https://bugzilla.kernel.org/attachment.cgi?id=311021
> Signed-off-by: Sandipan Das <sandipan.das@amd.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791791463.git.sandipan.das@amd.com?part=1


  reply	other threads:[~2026-10-12  7:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  7:53 [PATCH 0/3] perf vendor events amd: Add Zen 6 data fabric events and metrics Sandipan Das
2026-10-12  7:53 ` [PATCH 1/3] perf vendor events amd: Add Zen 6 data fabric events Sandipan Das
2026-10-12  7:59   ` sashiko-bot [this message]
2026-10-12  7:53 ` [PATCH 2/3] perf vendor events amd: Add Zen 6 data fabric metrics Sandipan Das
2026-10-12  8:02   ` sashiko-bot
2026-10-12  7:53 ` [PATCH 3/3] perf vendor events amd: Remove "PerPkg" from Zen 6 memory controller metrics Sandipan Das
2026-10-12  7:59   ` sashiko-bot
2026-10-12 21:00 ` [PATCH 0/3] perf vendor events amd: Add Zen 6 data fabric events and metrics Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-167816@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sandipan.das@amd.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox