Re: [PATCH v7 05/15] perf annotate-arm64: Support load instruction tracking

[sashiko-bot@kernel.org]

> Extend update_insn_state_arm64() to handle load instructions, tracking
> register state changes when data is loaded from memory to registers.
> 
> Two main categories are considered: standard load (e.g, ldr variants)
> and load pair (ldp), for example:
> 
>   ldr dst, [src, #imm]
>   ldp dst1, dst2, [src, #imm]
> 
> For data type propagation, a load pair can be treated as two standard
> loads combined, first loading dst1 and then dst2. The difference is
> that when loading dst2, an additional memory spacing 'mem_spacing' after
> the first load must be added. This mem_spacing can be derived from the
> instruction mnemonic and the size of the dst register. Each load operation
> is handled by introducing propagate_load_reg_state().
> [ ... ]
>   final result: type='struct task_struct'
> 
> Reviewed-by: Ian Rogers <irogers@google.com>
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>
> Signed-off-by: Tengda Wu <wutengda@huaweicloud.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791629326.git.wutengda@huaweicloud.com?part=5