From: sashiko-bot@kernel.org
To: "Haris Okanovic" <harisokn@amazon.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/4] perf/core: Fix perf_pmu_migrate_context() leaving events behind
Date: Tue, 13 Oct 2026 19:06:25 +0000 [thread overview]
Message-ID: <sashiko-outbox-170378@kernel.org> (raw)
In-Reply-To: <20261013185603.1347265-2-harisokn@amazon.com>
> __perf_pmu_remove() walks the group leaders of a CPU and PMU with
> perf_event_groups_for_cpu_pmu(), removing each one as it goes.
> perf_remove_from_context() takes the leader out of the groups rbtree,
> after which rb_next() on that node returns NULL, prematurely ending the
> walk. Other groups stay behind in the source context.
>
> On CPU hotplug, they are then torn down with the dying CPU. They keep
> running until teardown, while the PMU's interrupt and migrated events
> are on a new CPU, which drivers rely on never happening.
>
> Walk ctx->event_list instead and pick out the PMU's events by their
> pmu_ctx.
>
> Fixes: bd2756811766 ("perf: Rewrite core context handling")
> Signed-off-by: Haris Okanovic <harisokn@amazon.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261013185603.1347265-1-harisokn@amazon.com?part=1
next prev parent reply other threads:[~2026-10-13 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 18:55 [PATCH 0/4] perf: Manage single-CPU PMU affinity in perf core Haris Okanovic
2026-10-13 18:56 ` [PATCH 1/4] perf/core: Fix perf_pmu_migrate_context() leaving events behind Haris Okanovic
2026-10-13 19:06 ` sashiko-bot [this message]
2026-10-13 18:56 ` [PATCH 2/4] perf/core: Add PERF_PMU_SCOPE_DEVICE Haris Okanovic
2026-10-13 19:11 ` sashiko-bot
2026-10-13 18:56 ` [PATCH 3/4] perf/core: Allow userspace to select a device PMU's CPU Haris Okanovic
2026-10-13 19:08 ` sashiko-bot
2026-10-13 18:56 ` [PATCH 4/4] perf/arm-cmn: Convert to PERF_PMU_SCOPE_DEVICE Haris Okanovic
2026-10-13 19:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-170378@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=harisokn@amazon.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox