Re: [PATCH v2 15/19] perf tests: Introduce a 'needs_mlock' suite flag

[sashiko-bot@kernel.org]

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Each perf instance maps one ring buffer per CPU, all charged to the same
> per user budget set in kernel.perf_event_mlock_kb, so suites that map
> them need to be told apart from the ones that don't, to later have them
> take turns using that budget while the other tests keep running in
> parallel.
> 
> Add the flag to 'struct test_suite' and a DEFINE_SUITE_NEEDS_MLOCK()
> variant for the suites using the DEFINE_SUITE() form.
> 
> Shell tests run perf, that maps ring buffers, so they are taken to need
> room in that budget by default; the ones that don't map them waive it in
> the requisites, a comma separated list in the parens ending their
> description line, e.g.:
> 
>   # perf stat tests (no_mlock)
> 
> "exclusive" is the catch-all that keeps a test from running alongside
> any other, so it runs alone, in sequence, and implies every other
> requisite, "no_mlock" waives the default, and more keywords are to come,
> each stating what a test needs, till the catch-all isn't needed anymore.
> 
> 'perf test requisites' lists what each test needs, reusing the listing
> routine and taking the same test name fragments and numbers as 'list'.
> 
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013201415.36428-1-acme@kernel.org?part=15