Re: [PATCH v2 09/10] perf config, intel-tpebs, env: Add __guarded_by and __must_hold annotations

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] perf: Missing POSIX libc header inclusions for musl compatibility
--

commit 8960a6e4824321506be07bc73e262a9ac1420f9c
Author: Ian Rogers <irogers@google.com>

perf config, intel-tpebs, env: Add __guarded_by and __must_hold annotations

This commit adds __guarded_by() and __must_hold() annotations to static
parser and config state, TPEBS state, and perf_env trees. It also fixes an
unlocked read in tpebs_stop() and transfers tpebs_cmd.out ownership to
prevent a double-close.

> diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c
> index 7c0b8b15bd10e..85dcf4f646976 100644
> --- a/tools/perf/util/intel-tpebs.c
> +++ b/tools/perf/util/intel-tpebs.c

[ ... ]

> @@ -236,15 +222,17 @@ static void *__sample_reader(void *arg __maybe_unused)
>  	tool.attr = perf_event__process_attr;
>  
>  	session = perf_session__new(&data, &tool);
> -	if (IS_ERR(session))
> +	if (IS_ERR(session)) {
> +		close(data.file.fd);

[Severity: Medium]
Does this file need standard POSIX header inclusions like <unistd.h> for musl
libc compatibility?

This file makes heavy use of POSIX functions such as close(), pipe(), read(),
write(), malloc(), and strlen(), but omits the standard headers. The patch
adds new usages of close() and modifies file descriptor ownership without
including the necessary headers to prevent musl build failures.

>  		return NULL;
> +	}
>  	perf_session__process_events(session);
>  	perf_session__delete(session);
>  
>  	return NULL;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013222622.1822619-1-irogers@google.com?part=9