From: sashiko-bot@kernel.org
To: "Aaron Tomlin" <atomlin@atomlin.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH perf-tools-next v5 2/5] perf ftrace: Support filtering return address comments
Date: Thu, 15 Oct 2026 01:22:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-172086@kernel.org> (raw)
In-Reply-To: <20261015011155.414667-3-atomlin@atomlin.com>
> When tracing with the Linux kernel's function graph tracer, enabling
> funcgraph-retaddr records the return address of each function entry as
> a comment in the trace stream (e.g. /* <-load_elf_phdrs+0x6c/0xb0 */).
> While valuable for tracing execution origins, these trailing comments
> can add considerable visual clutter to the call graph, particularly
> when examining deeply nested call trees or when synthesising higher-level
> abstractions.
>
> Introduce support for filtering out return address comments from
> function graph trace output. Provide a standalone --filter-retaddr
> flag.
>
> Key aspects of this implementation:
>
> 1. Return address parsing and filtering
> [ ... ]
> processing") in tools/perf/tests/ftrace.c to validate comment
> parsing and string filtering across all supported formats.
>
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015011155.414667-1-atomlin@atomlin.com?part=2
next prev parent reply other threads:[~2026-10-15 1:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 1:11 [PATCH perf-tools-next v5 0/5] perf ftrace: Support inlined functions and display enhancements in function graph tracer Aaron Tomlin
2026-10-15 1:11 ` [PATCH perf-tools-next v5 1/5] perf ftrace: Optimise __cmd_ftrace() stack frame with strbuf streaming Aaron Tomlin
2026-10-15 1:20 ` sashiko-bot
2026-10-15 1:11 ` [PATCH perf-tools-next v5 2/5] perf ftrace: Support filtering return address comments Aaron Tomlin
2026-10-15 1:22 ` sashiko-bot [this message]
2026-10-15 1:11 ` [PATCH perf-tools-next v5 3/5] perf ftrace: Support display of inlined functions in function graph tracer Aaron Tomlin
2026-10-15 1:24 ` sashiko-bot
2026-10-15 1:11 ` [PATCH perf-tools-next v5 4/5] perf ftrace: Support omitting execution duration " Aaron Tomlin
2026-10-15 1:19 ` sashiko-bot
2026-10-15 1:11 ` [PATCH perf-tools-next v5 5/5] perf ftrace: Filter extraneous functions " Aaron Tomlin
2026-10-15 1:24 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172086@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=atomlin@atomlin.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox