From: sashiko-bot@kernel.org
To: "Leo Yan" <leo.yan@arm.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/2] coresight: trbe: Order padding before publishing AUX head
Date: Thu, 15 Oct 2026 16:09:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-173140@kernel.org> (raw)
In-Reply-To: <20261015-add_barriers_for_perf_aux_output_skip-v1-2-5847d0578859@arm.com>
> TRBE fills gaps in the AUX buffer before advancing aux_head. Neither
> perf_aux_output_skip() nor perf_aux_output_end() guarantees ordering of
> these CPU stores before publishing the new head.
>
> Add smp_wmb() after memset() in __trbe_pad_buf(). This covers alignment
> padding published by perf_aux_output_skip() and the overwrite erratum
> padding written by trbe_get_trace_size() before perf_aux_output_end().
>
> Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver")
> Assisted-by: LLM
> Signed-off-by: Leo Yan <leo.yan@arm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-add_barriers_for_perf_aux_output_skip-v1-0-5847d0578859@arm.com?part=2
prev parent reply other threads:[~2026-10-15 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 15:51 [PATCH 0/2] perf: Order SPE and TRBE padding before publishing AUX head Leo Yan
2026-10-15 15:51 ` [PATCH 1/2] perf: arm_spe: Order " Leo Yan
2026-10-15 16:03 ` sashiko-bot
2026-10-15 15:51 ` [PATCH 2/2] coresight: trbe: " Leo Yan
2026-10-15 16:09 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173140@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox