Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Besar Wicaksono" <bwicaksono@nvidia.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/6] perf jevents: Process model files before sys subdirectories
Date: Mon, 19 Oct 2026 16:47:49 +0000	[thread overview]
Message-ID: <sashiko-outbox-177936@kernel.org> (raw)
In-Reply-To: <20261019164241.403644-2-bwicaksono@nvidia.com>

> jevents walks each directory in name order, mixing files and
> subdirectories. When it reaches a sys/ directory inside a model
> directory, process_one_file() flushes the model's pending tables and
> switches the pending table name to the sys table. After the walk
> returns from sys/, nothing switches it back, so model JSON files whose
> names sort after "sys" (for example tlb.json) are added to the sys
> table. Sys tables are only matched by Compat against uncore PMU
> identifiers, so these core events are lost: perf list doesn't show
> them and perf stat rejects them.
> 
> Visit the files of a directory before its subdirectories, so that all
> of a model's JSON files are added to the model's table before a sys/
> subdirectory is processed. The generated pmu-events.c is unchanged for
> the existing event directories.
> 
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019164241.403644-1-bwicaksono@nvidia.com?part=1


  reply	other threads:[~2026-10-19 16:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:42 [PATCH 0/6] perf jevents: Add NVIDIA Tegra410 uncore PMU events and metrics Besar Wicaksono
2026-10-19 16:42 ` [PATCH 1/6] perf jevents: Process model files before sys subdirectories Besar Wicaksono
2026-10-19 16:47   ` sashiko-bot [this message]
2026-10-19 16:42 ` [PATCH 2/6] perf jevents: Add support for NVIDIA Tegra410 UCF PMU aliasing Besar Wicaksono
2026-10-19 16:49   ` sashiko-bot
2026-10-19 16:42 ` [PATCH 3/6] perf jevents: Add support for NVIDIA Tegra410 PCIE " Besar Wicaksono
2026-10-19 16:50   ` sashiko-bot
2026-10-19 17:50   ` Chun-Tse Shao
2026-10-19 16:42 ` [PATCH 4/6] perf jevents: Add support for NVIDIA Tegra410 PCIE-TGT " Besar Wicaksono
2026-10-19 16:47   ` sashiko-bot
2026-10-19 23:18   ` Ian Rogers
2026-10-20 22:01     ` Besar Wicaksono
2026-10-19 16:42 ` [PATCH 5/6] perf jevents: Add support for NVIDIA Tegra410 CPU Memory Latency " Besar Wicaksono
2026-10-19 16:47   ` sashiko-bot
2026-10-19 16:42 ` [PATCH 6/6] perf jevents: Add support for NVIDIA Tegra410 C2C " Besar Wicaksono
2026-10-19 16:47   ` sashiko-bot
2026-10-19 17:23 ` [PATCH 0/6] perf jevents: Add NVIDIA Tegra410 uncore PMU events and metrics James Clark
2026-10-20 19:15   ` Arnaldo Carvalho de Melo
2026-10-20 20:32     ` Ian Rogers
2026-10-20 20:38       ` Arnaldo Melo
2026-10-20 22:14       ` Besar Wicaksono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-177936@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bwicaksono@nvidia.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox