Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Aaron Tomlin" <atomlin@atomlin.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH perf-tools-next v9 6/6] perf ftrace: Filter extraneous functions in function graph tracer
Date: Wed, 21 Oct 2026 02:43:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-179712@kernel.org> (raw)
In-Reply-To: <20261021023337.809936-7-atomlin@atomlin.com>

> When tracing with the function graph tracer using a targeted filter
> (-G or --graph-funcs), users occasionally observe unrelated functions in
> the trace output:
> 
>     1. Top-level functions (e.g. most notably
>        finish_task_switch.isra.0()) appearing before or alongside the
>        requested target function. This occurs because clearing and
>        rewriting set_graph_function creates a transient window where
>        remote CPUs still observe an empty filter (tracing all
>        functions) before RCU synchronisation completes, coupled with
>        perf ftrace sleeping in poll() on trace_pipe right as tracing
>        starts.
> 
>     2. Detached/orphan calls inside the target callgraph
>        (e.g. housekeeping_any_cpu() and arch_irq_work_raise())
> [ ... ]
>        detached orphan suppression, glob matching, deep stack
>        traversal, dropped-orphan recovery, and orphan exit collision
>        prevention.
> 
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021023337.809936-1-atomlin@atomlin.com?part=6


      reply	other threads:[~2026-10-21  2:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21  2:33 [PATCH perf-tools-next v9 0/6] perf ftrace: Support inlined functions and display enhancements in function graph tracer Aaron Tomlin
2026-10-21  2:33 ` [PATCH perf-tools-next v9 1/6] perf ftrace: Optimise __cmd_ftrace() stack frame with strbuf streaming Aaron Tomlin
2026-10-21  2:48   ` sashiko-bot
2026-10-21  2:33 ` [PATCH perf-tools-next v9 2/6] perf ftrace: Support filtering return address comments Aaron Tomlin
2026-10-21  2:38   ` sashiko-bot
2026-10-21  2:33 ` [PATCH perf-tools-next v9 3/6] perf symbol: Introduce vmlinux_path__find() helper Aaron Tomlin
2026-10-21  2:45   ` sashiko-bot
2026-10-21  2:33 ` [PATCH perf-tools-next v9 4/6] perf ftrace: Support display of inlined functions in function graph tracer Aaron Tomlin
2026-10-21  2:42   ` sashiko-bot
2026-10-21  2:33 ` [PATCH perf-tools-next v9 5/6] perf ftrace: Support omitting execution duration " Aaron Tomlin
2026-10-21  2:38   ` sashiko-bot
2026-10-21  2:33 ` [PATCH perf-tools-next v9 6/6] perf ftrace: Filter extraneous functions " Aaron Tomlin
2026-10-21  2:43   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-179712@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=atomlin@atomlin.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox