From: sashiko-bot@kernel.org
To: "TAKANO Mitsuhiro" <takano32@gmail.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf test: Skip the extra metric line for stalled_cycles_per_instruction
Date: Thu, 22 Oct 2026 02:58:25 +0000 [thread overview]
Message-ID: <sashiko-outbox-180891@kernel.org> (raw)
In-Reply-To: <20261022024950.264235-1-takano32@gmail.com>
> The STD output linter maps one metric to each default event and stops at
> the first line that shows a different one. stalled_cycles_per_instruction
> is computed as max(stalled-cycles-frontend, stalled-cycles-backend) /
> instructions, so its event set differs from the one behind
> backend_cycles_idle and perf stat prints it on a line of its own: a
> second stalled-cycles-backend line carrying that metric. The linter
> rejects it with "wrong event metric. expected backend_cycles_idle in
> ...".
>
> Metrics printed on their own line are already skipped
> (skip_metric=("tma_" "TopdownL1")); add this one to that list.
>
> Verified on an Ampere Altra (arm64, Neoverse-N1): `perf test "perf stat
> STD output linter"` fails before the change and passes after it. Only
> the linter is changed; the perf stat output is untouched.
>
> Fixes: c7adeb0974f1 ("perf jevents: Add set of common metrics based on default ones")
> Assisted-by: LLM
> Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261022024950.264235-1-takano32@gmail.com?part=1
prev parent reply other threads:[~2026-10-22 2:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 2:49 [PATCH] perf test: Skip the extra metric line for stalled_cycles_per_instruction TAKANO Mitsuhiro
2026-10-22 2:58 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-180891@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=takano32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox