Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Florian Fainelli" <florian.fainelli@broadcom.com>
Cc: "open list:PERFORMANCE EVENTS SUBSYSTEM"
	<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH] perf print_insn: Include sys/types.h for ssize_t
Date: Mon, 26 Oct 2026 17:48:06 +0000	[thread overview]
Message-ID: <sashiko-outbox-185589@kernel.org> (raw)
In-Reply-To: <20261026174535.3157580-1-florian.fainelli@broadcom.com>

> print_insn.h declares fprintf_insn_asm() with an ssize_t return type but
> does not include the header defining that type. This causes builds where
> stdio.h does not provide ssize_t to fail when compiling util/print_insn.c:
> 
>   util/print_insn.h:21:1: error: unknown type name 'ssize_t'
> 
> Include sys/types.h so the header provides its own dependency for ssize_t.
> 
> Fixes: 218c200f677d ("perf script: Consolidate capstone print functions")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026174535.3157580-1-florian.fainelli@broadcom.com?part=1


  reply	other threads:[~2026-10-26 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 17:45 [PATCH] perf print_insn: Include sys/types.h for ssize_t Florian Fainelli
2026-10-26 17:48 ` sashiko-bot [this message]
2026-10-26 18:27 ` James Clark
2026-10-27 20:39   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-185589@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox