From: sashiko-bot@kernel.org
To: "Matt Turner" <mattst88@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 4/5] alpha/perf: attach ProfileMe status as PERF_SAMPLE_RAW data
Date: Fri, 30 Oct 2026 04:10:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-190287@kernel.org> (raw)
In-Reply-To: <20261030-alpha-profileme-v2-4-c702f1c65272@gmail.com>
> A ProfileMe sample's PC alone does not say what happened to the profiled
> instruction. I_STAT and PCTR_CTL do: whether it trapped and why, was
> mispredicted, stalled, or was killed on a wrong path, and what PCTR1
> counted during the window.
>
> With PERF_SAMPLE_RAW, attach PMPC, I_STAT and PCTR_CTL to each ProfileMe
> sample in a versioned struct alpha_profileme_sample. PMPC is included
> because a PALmode PMPC is not the sample's IP. Killed instructions can be
> told apart by PM_KILLED_BM and VAL. The 64-bit fields are packed after
> the 32-bit version, since the payload follows the 32-bit raw size in the
> sample record: they are then 8-byte aligned in the record, which needs
> no padding.
>
> Signed-off-by: Matt Turner <mattst88@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261030-alpha-profileme-v2-0-c702f1c65272@gmail.com?part=4
next prev parent reply other threads:[~2026-10-30 4:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 4:03 [PATCH v2 0/5] alpha/perf: add ProfileMe sampling Matt Turner
2026-10-30 4:03 ` [PATCH v2 1/5] alpha/perf: pass PERFMON_CMD_LOGGING_ALL to the logging options call Matt Turner
2026-10-30 4:07 ` sashiko-bot
2026-10-30 4:04 ` [PATCH v2 2/5] alpha/perf: add sysfs format and event attributes Matt Turner
2026-10-30 4:07 ` sashiko-bot
2026-10-30 4:04 ` [PATCH v2 3/5] alpha/perf: implement ProfileMe sampling Matt Turner
2026-10-30 4:04 ` [PATCH v2 4/5] alpha/perf: attach ProfileMe status as PERF_SAMPLE_RAW data Matt Turner
2026-10-30 4:10 ` sashiko-bot [this message]
2026-10-30 4:04 ` [PATCH v2 5/5] alpha/perf: optionally randomize the ProfileMe sampling interval Matt Turner
2026-10-30 4:11 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-190287@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox