Re: [PATCH v3 1/2] perf symbol: Add dso__load_symsrc()

[sashiko-bot@kernel.org]

> dso__load() goes through the candidate files for a DSO, such as the DSO
> itself, separate debuginfo found through .gnu_debuglink, the build-id
> cache and /usr/lib/debug, checks their build-ids, records the one with a
> symbol table in dso__symsrc_filename(), and then reads and demangles
> that symbol table.
> 
> The DWARF unwinders depend on the first part. dso__symsrc_filename() is
> how they find a separate debuginfo file, for instance to use its
> .debug_frame, and libdw's build-id cache fallback needs the build-id
> that dso__load() reads when the DSO doesn't have one yet. They get both
> today as a side effect of loading the symbols of every frame they visit.
> 
> Add dso__load_symsrc(), which does the same search, inside the DSO's
> mount namespace and honouring --symfs but stops before reading any
> symbols. A new symsrc_loaded flag records that it ran, so the search is
> done once per DSO, and the DSO's symbols stay unloaded, so dso__load()
> still loads them when they are wanted. Kernel and perf map DSOs are
> skipped, as the unwinders only handle user space ELF images.
> 
> No functional change on its own; the next patch uses it.
> 
> Signed-off-by: Matthew Wood <thepacketgeek@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030193237.1440673-1-thepacketgeek@gmail.com?part=1