From: sashiko-bot@kernel.org
To: "Matt Turner" <mattst88@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 3/7] alpha/perf: clear PERF_HES_UPTODATE when an event starts counting
Date: Sun, 01 Nov 2026 19:39:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-192626@kernel.org> (raw)
In-Reply-To: <20261101-alpha-profileme-v3-3-92d511b5a044@gmail.com>
> alpha_pmu_add() sets PERF_HES_UPTODATE and maybe_change_configuration()
> then programs and enables the counter, but nothing clears the flag until
> the first alpha_pmu_start(). In that window alpha_pmu_stop() with
> PERF_EF_UPDATE skips the count update, because the flag claims the count
> is current. Since the next reload rewrites the counter, everything
> counted since the event was added is lost.
>
> perf_adjust_freq_unthr_events() does this on the first tick
> after an event in frequency mode is scheduled in, which is the default
> for perf record, and it then sees no count to adjust the period with.
>
> Clear the flag where the event starts counting. alpha_pmu_add() cannot
> do it, since the event is not programmed until the PMU is enabled, and
> stopping it before then must not read the counter.
>
> Fixes: a4eaf7f14675 ("perf: Rework the PMU methods")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Matt Turner <mattst88@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261101-alpha-profileme-v3-0-92d511b5a044@gmail.com?part=3
next prev parent reply other threads:[~2026-11-01 19:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 19:28 [PATCH v3 0/7] alpha/perf: add ProfileMe sampling Matt Turner
2026-11-01 19:28 ` [PATCH v3 1/7] alpha/perf: pass PERFMON_CMD_LOGGING_ALL to the logging options call Matt Turner
2026-11-01 19:31 ` sashiko-bot
2026-11-01 19:28 ` [PATCH v3 2/7] alpha/perf: add sysfs format and event attributes Matt Turner
2026-11-01 19:33 ` sashiko-bot
2026-11-01 19:28 ` [PATCH v3 3/7] alpha/perf: clear PERF_HES_UPTODATE when an event starts counting Matt Turner
2026-11-01 19:39 ` sashiko-bot [this message]
2026-11-01 19:28 ` [PATCH v3 4/7] alpha/perf: do not report user registers from the entry code Matt Turner
2026-11-01 19:48 ` sashiko-bot
2026-11-01 19:28 ` [PATCH v3 5/7] alpha/perf: implement ProfileMe sampling Matt Turner
2026-11-01 20:12 ` sashiko-bot
2026-11-01 19:28 ` [PATCH v3 6/7] alpha/perf: attach ProfileMe status as PERF_SAMPLE_RAW data Matt Turner
2026-11-01 20:17 ` sashiko-bot
2026-11-01 19:28 ` [PATCH v3 7/7] alpha/perf: optionally randomize the ProfileMe sampling interval Matt Turner
2026-11-01 20:25 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-192626@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox