Re: [PATCH v3 11/18] perf arm-spe: Use generic snapshot search

[sashiko-bot@kernel.org]

> The new generic snapshot search gives a similar result as the
> reimplemented version of it here. One slight difference is in the
> pointer fixup. SPE has:
> 
>   *head += mm->len;
>   *old = *head - mm->len;
> 
> Which gives exactly the same result but written in reverse order to the
> generic one:
> 
>   *old = *head;
>   *head += mm->len;
> 
> SPE also had a special fixup cases (if (head >= buffer_size)):
> 
> [ ... ]
> [head..mm->len] contains zero data. This should be fine, as zero data
> are treated as PAD packets and discarded during decoding.
> 
> Reviewed-by: Leo Yan <leo.yan@arm.com>
> Signed-off-by: James Clark <james.clark@linaro.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-james-cs-unformatted-per-thread-fix-v3-0-dbcb0c281b9b@linaro.org?part=11