From: sashiko-bot@kernel.org
To: "Matt Turner" <mattst88@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 11/11] alpha/perf: sample only retired instructions for precise events
Date: Tue, 03 Nov 2026 20:48:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-196015@kernel.org> (raw)
In-Reply-To: <20261103-alpha-profileme-v5-11-bbe3937fbf3a@gmail.com>
> ProfileMe samples include instructions killed on a wrong path, which
> show up as hot spots in perf report although they did no work. On an
> EV7 loop with a randomly mispredicted branch, 19% of the samples were
> killed before being mapped and another 48% later.
>
> PEBS and AMD IBS op samples are of retired instructions only, so make
> precise_ip imply the retired filter, unless filters are given. The
> profileme bit still selects every sample. With cycles:p, both kinds of
> killed sample went to 0%.
>
> DTB miss samples, whose instruction is aborted, are then dropped too:
> their data source now needs cpu/cycles,trapped/p.
>
> Suggested-by: Ian Rogers <irogers@google.com>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Matt Turner <mattst88@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-alpha-profileme-v5-0-bbe3937fbf3a@gmail.com?part=11
prev parent reply other threads:[~2026-11-03 20:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 20:37 [PATCH v5 00/11] alpha/perf: add ProfileMe sampling Matt Turner
2026-11-03 20:37 ` [PATCH v5 01/11] alpha/perf: pass PERFMON_CMD_LOGGING_ALL to the logging options call Matt Turner
2026-11-03 20:40 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 02/11] alpha/perf: add sysfs format and event attributes Matt Turner
2026-11-03 20:40 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 03/11] alpha/perf: clear PERF_HES_UPTODATE when an event starts counting Matt Turner
2026-11-03 20:43 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 04/11] alpha/perf: do not report user registers from the entry code Matt Turner
2026-11-03 20:46 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 05/11] alpha/perf: implement ProfileMe sampling Matt Turner
2026-11-03 20:37 ` [PATCH v5 06/11] alpha/perf: attach ProfileMe status as PERF_SAMPLE_RAW data Matt Turner
2026-11-03 20:43 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 07/11] alpha/perf: optionally randomize the ProfileMe sampling interval Matt Turner
2026-11-03 20:45 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 08/11] alpha/perf: report the ProfileMe window count as the sample weight Matt Turner
2026-11-03 20:41 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 09/11] alpha/perf: report the data source of ProfileMe DTB misses Matt Turner
2026-11-03 20:48 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 10/11] alpha/perf: add ProfileMe sample filters Matt Turner
2026-11-03 20:43 ` sashiko-bot
2026-11-03 20:37 ` [PATCH v5 11/11] alpha/perf: sample only retired instructions for precise events Matt Turner
2026-11-03 20:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-196015@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox