From: sashiko-bot@kernel.org
To: "Bradley Morgan" <brads@mainlining.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/3] tools: pass the unused prctl() args explicitly for PR_FUTEX_HASH
Date: Thu, 05 Nov 2026 00:35:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-198365@kernel.org> (raw)
In-Reply-To: <20261105003129.3130709-2-brads@mainlining.org>
> prctl() is declared variadic in sys/prctl.h, so an argument the caller
> leaves out of the call is whatever that register happens to hold.
> Neither file passes all five. The two SET_SLOTS calls leave arg5 out
> and the two GET_SLOTS calls leave arg3, arg4 and arg5 out, so those are
> whatever the registers hold. The kernel does not look at them today so
> it works, but it works by luck. I checked that against a running
> kernel, garbage in arg5 on SET_SLOTS and in all three on GET_SLOTS are
> accepted.
>
> Pass the zeros. No functional change.
>
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105003129.3130709-2-brads@mainlining.org?part=1
prev parent reply other threads:[~2026-11-05 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 0:31 [PATCH 0/3] two small fixes out of kernel/sys.c Bradley Morgan
2026-11-05 0:31 ` [PATCH 1/3] tools: pass the unused prctl() args explicitly for PR_FUTEX_HASH Bradley Morgan
2026-11-05 0:35 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-198365@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=brads@mainlining.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox