Re: [PATCH v2 2/3] perf: do not call list_for_each_entry_safe() on uninitalized list

[sashiko-bot@kernel.org]

> In test__pmu_config_helpers(), when evlist__new() fails, the code jumped
> to the err_out label, which calls parse_events_terms__exit(&terms). At
> that point parse_events_terms__init(&terms) has not run yet, so the
> terms list head is uninitialized and list_for_each_entry_safe() walks a
> garbage pointer.
> 
> Fixes this compiler warning:
> In function ‘parse_events_terms__exit’,
>     inlined from ‘test__pmu_config_helpers’ at tests/pmu.c:296:2:
> util/parse-events.c:2849:2: warning: ‘terms.terms.next’ may be used uninitia
> tests/pmu.c: In function ‘test__pmu_config_helpers’:
> tests/pmu.c:209:28: note: ‘terms’ declared here
> 
> Assisted-by: LLM
> Fixes: 8e2ef85c66dc ("perf tests: Test evsel__set_config_if_unset() and config change tracking")
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/8b245572903b8c4ed0dc569d7a71a8f4974e2455.1793867553.git.jirislaby@kernel.org?part=2