Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [RFC PATCH v3 2/3] perf build: Prefer zlib-rs over zlib when available
Date: Thu, 05 Nov 2026 18:26:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-199760@kernel.org> (raw)
In-Reply-To: <20261105180923.3441359-3-irogers@google.com>

> Detect and prefer zlib-rs over C zlib in the perf build unless disabled
> with NO_ZLIB_RS=1 (or NO_ZLIB=1 / NO_RUST=1):
> 
> - Move Rust compiler detection ahead of zlib detection in
>   tools/perf/Makefile.config and use feature_check + feature_rust_lib for
>   zlib-rs, setting both HAVE_ZLIB_SUPPORT and HAVE_ZLIB_RS_SUPPORT when
>   zlib-rs is used and falling back to C zlib (-lz) otherwise.
> - Replace -lz with $(ZLIB_LIBS) in DWARFLIBS and llvm-config
>   --system-libs so static libdw/libelf and libLLVM configurations use
>   the selected zlib implementation.
> - Build and clean libz_rs.a in $(OUTPUT)libz_rs/, pass ZLIB_CFLAGS when
>   building static libbpf, and share RUST_OUTPUT with the host bootstrap
>   bpftool build in tools/perf/bpf_skel.mak.
> - Expose 'zlib-rs' in 'perf check feature' / 'perf version --build-options'
>   and document it in perf-check.txt.
> - Add zlib-rs package mappings to tools/perf/scripts/install-build-deps.sh
>   and NO_ZLIB / NO_ZLIB_RS build tests to tools/perf/tests/make.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105180923.3441359-1-irogers@google.com?part=2


  reply	other threads:[~2026-11-05 18:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 18:09 [RFC PATCH v3 0/3] tools: Add Rust library build infrastructure and prefer zlib-rs Ian Rogers
2026-11-05 18:09 ` [RFC PATCH v3 1/3] tools build: Add Rust library build infrastructure and zlib-rs feature test Ian Rogers
2026-11-05 18:30   ` sashiko-bot
2026-11-05 18:53   ` bot+bpf-ci
2026-11-05 18:09 ` [RFC PATCH v3 2/3] perf build: Prefer zlib-rs over zlib when available Ian Rogers
2026-11-05 18:26   ` sashiko-bot [this message]
2026-11-05 18:53   ` bot+bpf-ci
2026-11-05 18:09 ` [RFC PATCH v3 3/3] bpftool: " Ian Rogers
2026-11-05 18:15   ` sashiko-bot
2026-11-05 18:53   ` bot+bpf-ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-199760@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox