Re: [PATCH v10 07/20] perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf vdso: missing Fixes trailer for locking regression in
  machine__findnew_vdso()
--

commit 4eb9a9569b89c8e8222d4936fcb66a2bd40347f4
Author: Ian Rogers <irogers@google.com>

> perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso()
>
> __machine__addnew_vdso() called __dsos__add(&machine->dsos, dso) without
> holding machine->dsos.lock, and machine__findnew_vdso() and
> __machine__findnew_compat() initialized machine->vdso_info and created
> temporary VDSO files without synchronization. Acquire
> machine->dsos.lock in write mode across machine->vdso_info
> initialization, duplicate checking via __dsos__find(), temporary file
> creation, dso__set_long_name(), and __dsos__add().
>
> Signed-off-by: Ian Rogers <irogers@google.com>

[Severity: Low]
As reported by Bart Van Assche on v2 [1], commit f649ed80f3ca ("perf dsos:
Tidy reference counting and locking") removed the write lock on
machine->dsos.lock from machine__findnew_vdso().  Should this include:

  Fixes: f649ed80f3ca ("perf dsos: Tidy reference counting and locking")

[1] https://lore.kernel.org/r/3f57ddf4-b1a7-4c91-8983-c8cd83d0f25c@acm.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106070344.329897-1-irogers@google.com?part=7