From: sashiko-bot@kernel.org
To: "Tiezhu Yang" <yangtiezhu@loongson.cn>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 2/2] perf tests: Use TEST_ASSERT_EQUAL for all watchpoint tests
Date: Fri, 06 Nov 2026 09:34:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-201117@kernel.org> (raw)
In-Reply-To: <20261106092808.6914-3-yangtiezhu@loongson.cn>
> Currently, WP_TEST_ASSERT_VAL uses TEST_ASSERT_VAL which only prints
> the failure message but drops the actual and expected counters. This
> makes debugging hard when a watchpoint test fails due to arch-specific
> hardware behavior or counter mismatches.
>
> Rename WP_TEST_ASSERT_VAL to WP_TEST_ASSERT_EQUAL and use the built-in
> TEST_ASSERT_EQUAL macro. This ensures that both the expected and actual
> counter values are automatically printed upon failure.
>
> Here is the log when executing "./perf test -v 'Read Only Watchpoint'".
>
> Before:
> FAILED tests/wp.c:90 RO watchpoint
>
> After:
> FAILED tests/wp.c:90 RO watchpoint (2 != 1)
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106092808.6914-1-yangtiezhu@loongson.cn?part=2
prev parent reply other threads:[~2026-11-06 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 9:28 [PATCH v1 0/2] perf tests: Fix and improve watchpoint tests Tiezhu Yang
2026-11-06 9:28 ` [PATCH v1 1/2] perf tests: Assign return value of ioctl in wp_modify test Tiezhu Yang
2026-11-06 9:36 ` sashiko-bot
2026-11-06 9:51 ` Tiezhu Yang
2026-11-06 9:28 ` [PATCH v1 2/2] perf tests: Use TEST_ASSERT_EQUAL for all watchpoint tests Tiezhu Yang
2026-11-06 9:34 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201117@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox