From: sashiko-bot@kernel.org
To: "Zhao Gongyi" <zhaogongyi@bytedance.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf/x86/amd: Avoid double-decrementing n_pair on failed transactions
Date: Mon, 09 Nov 2026 11:28:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-204870@kernel.org> (raw)
In-Reply-To: <20261109111909.31712-1-zhaogongyi@bytedance.com>
> On a failed PERF_PMU_TXN_ADD commit, x86_schedule_events() releases
> constraints for newly added pair events. The AMD put callback decrements
> n_pair, and x86_pmu_cancel_txn() then subtracts n_txn_pair for the same
> events. This undercounts active pairs and overstates the GP counter budget
> for later scheduling.
>
> Leave transaction rollback to x86_pmu_cancel_txn(). Keep the AMD
> decrement for constraint releases outside transactions.
>
> Fixes: 871a93b0aad6 ("perf/x86: Fix n_pair for cancelled txn")
> Signed-off-by: Zhao Gongyi <zhaogongyi@bytedance.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109111909.31712-1-zhaogongyi@bytedance.com?part=1
next prev parent reply other threads:[~2026-11-09 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 11:19 [PATCH] perf/x86/amd: Avoid double-decrementing n_pair on failed transactions Zhao Gongyi
2026-11-09 11:28 ` sashiko-bot [this message]
2026-11-11 6:54 ` Hang Zhengyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204870@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhaogongyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox