Re: [PATCH v3 01/20] perf map_browser: Fix browser index heap corruption by computing on demand

[sashiko-bot@kernel.org]

> Commit 259dce914e93 ("perf symbol: Remove symbol_name_rb_node") removed
> the 24-byte symbol_name_rb_node reservation from symbol_conf.priv_size,
> but left symbol__browser_index() in ui/browsers/map.c subtracting
> sizeof(struct rb_node) + sizeof(u32) (28 bytes on 64-bit) ahead of
> struct symbol. In 'perf report -v' and 'perf c2c report -v',
> symbol_conf.priv_size is sizeof(struct annotation) + sizeof(u32)
> (20 bytes on 64-bit), so opening the TUI map browser writes a u32 index
> 8 bytes before each symbol's calloc() buffer, corrupting heap metadata.
> 
> Remove symbol__browser_index() in ui/browsers/map.c and compute the TUI
> map browser index on demand in map_browser__search() by walking the map
> browser's symbol entries when the user searches with '/'.
> 
> While this changes finding a symbol's display row index in
> map_browser__search() from O(1) to O(N) in the number of symbols in that
> [ ... ]
> overhead, so remove the verbose > 0 restriction and allow '/' search in
> the map browser unconditionally.
> 
> Fixes: 259dce914e93 ("perf symbol: Remove symbol_name_rb_node")
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110220803.2503416-1-irogers@google.com?part=1