Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hang Zhengyang" <hang.zhengyang1010@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf parse-events: Don't report unreadable tracepoint globs as unknown
Date: Wed, 11 Nov 2026 02:28:45 +0000	[thread overview]
Message-ID: <sashiko-outbox-208086@kernel.org> (raw)
In-Reply-To: <20261111-tp-glob-errno-v2-1-ca45efb07d31@gmail.com>

> From: Hang Zhengyang <hang.zhengyang1010@gmail.com>
> 
> As a normal user, a tracepoint glob gets the wrong error:
> 
>   $ perf stat -e 'syscalls:*' true
>   event syntax error: 'syscalls:*'
>                        \___ unknown tracepoint
> 
>   Error:  File /sys/kernel/tracing//events/syscalls/* not found.
>   Hint:   Perhaps this kernel misses some CONFIG_ setting to enable this feature?.
> 
> add_tracepoint_multi_sys() returns ENOENT when nothing matched and
> drops the error from reading the directories.  Return that error
> instead, so the glob reports what a plain tracepoint name does:
> 
>   $ perf stat -e 'syscalls:*' true
>   event syntax error: 'syscalls:*'
>                        \___ can't access trace events
> 
>   Error:  No permissions to read /sys/kernel/tracing//events/syscalls/*
>   Hint:   Try 'sudo mount -o remount,mode=755 /sys/kernel/tracing/'
> 
> Fixes: d002aab87de8 ("perf tp_pmu: Factor existing tracepoint logic to new file")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Hang Zhengyang <hang.zhengyang1010@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-tp-glob-errno-v2-1-ca45efb07d31@gmail.com?part=1


      reply	other threads:[~2026-11-11  2:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  1:48 [PATCH v2] perf parse-events: Don't report unreadable tracepoint globs as unknown Hang Zhengyang via B4 Relay
2026-11-11  2:28 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-208086@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=hang.zhengyang1010@gmail.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox