From: sashiko-bot@kernel.org
To: "TAKANO Mitsuhiro" <takano32@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] arm64: perf: Drop the example the userspace counter section points at
Date: Wed, 11 Nov 2026 02:57:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-208137@kernel.org> (raw)
In-Reply-To: <20261111023550.1971639-1-takano32@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] docs: arm64: perf: commit message includes v1 changelog and
repetitive text
--
commit 4f292c888b9c6465b91000fd55cd46c1bc198a65
Author: TAKANO Mitsuhiro <takano32@gmail.com>
> arm64: perf: Drop the example the userspace counter section points at
>
> Documentation/arch/arm64/perf.rst points at
> tools/perf/arch/arm64/tests/user-events.c, in the text and in the link
> target, but the file does not exist: no file of that name is in
> tools/perf/arch/arm64/tests/, and no commit in the history leading to this
> base has added one.
>
> The section already describes how to use the libperf helpers and points at
> tools/lib/perf/tests/test-evsel.c as the example, so the sentence that
> sends the reader elsewhere is redundant. Remove it and the link target
> rather than pointing at another test, and move the instruction for running
> the example into the How-to section, next to the reference it belongs to.
>
> v1 pointed the reference at tools/perf/tests/mmap-basic.c. The review said
> that file is a confusing example and that the section above already covers
> the how-to, which is what this version does.
>
> Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>
[Severity: Low]
This isn't a bug, but the v1 review history in the third paragraph belongs
below the --- separator line rather than in the permanent commit log, per
Documentation/process/submitting-patches.rst.
Also, the first paragraph repeats that
tools/perf/arch/arm64/tests/user-events.c is missing in three different
ways ("the file does not exist", "no file of that name is in ...", and
"no commit in the history ... has added one"), which could be trimmed for
conciseness.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111023550.1971639-1-takano32@gmail.com?part=1
next prev parent reply other threads:[~2026-11-11 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 23:45 [PATCH] arm64: perf: Fix the userspace counter example link TAKANO Mitsuhiro
2026-11-06 23:52 ` sashiko-bot
2026-11-09 11:19 ` James Clark
2026-11-11 2:35 ` [PATCH v2] arm64: perf: Drop the example the userspace counter section points at TAKANO Mitsuhiro
2026-11-11 2:57 ` sashiko-bot [this message]
2026-11-11 3:44 ` [PATCH v3] " TAKANO Mitsuhiro
2026-11-11 3:47 ` sashiko-bot
2026-11-11 9:53 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208137@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=takano32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox