From: sashiko-bot@kernel.org
To: "Casey Chen" <cachen@purestorage.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf hist: Don't update the map of a hist entry to a NULL map
Date: Thu, 12 Nov 2026 00:16:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-209892@kernel.org> (raw)
In-Reply-To: <20261111234156.2276500-1-cachen@purestorage.com>
> perf c2c report, including --stats, segfaults on c2c data recorded on
> a loaded system:
>
> map__find_symbol
> hists__findnew_entry
> __hists__add_entry
> process_sample_event (builtin-c2c.c)
> perf_session__deliver_event
> ordered_events__deliver_event
> __ordered_events__flush
> perf_session__process_user_event
> perf_session__process_events
> perf_c2c__report
>
> When a new sample matches an existing hist entry whose map differs,
> [ ... ]
> an AI coding assistant. The patch was also reviewed with Sashiko, which
> reported no issues. I reviewed and tested the change.
>
> Fixes: ac01c8c42465 ("perf hist: Update hist symbol when updating maps")
> Signed-off-by: Casey Chen <cachen@purestorage.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111234156.2276500-1-cachen@purestorage.com?part=1
prev parent reply other threads:[~2026-11-12 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 23:41 [PATCH] perf hist: Don't update the map of a hist entry to a NULL map Casey Chen
2026-11-12 0:16 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209892@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cachen@purestorage.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox