From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 1/5] tools build: Fix version-ge3 and version-lt3 for <3-part versions
Date: Thu, 12 Nov 2026 01:18:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-210057@kernel.org> (raw)
In-Reply-To: <20261112011514.4032822-2-irogers@google.com>
> version-ge3 and version-lt3 concatenate their two arguments as
> "$(1).$(2)" and parse fields $1..$6 with awk -F'.'. When $(1) is empty
> or has fewer than three dot-separated components (for example GCC's
> 1- or 2-part -dumpversion output), fields $4..$6 shift across the
> boundary between $(1) and $(2). In particular, calling version-lt3 with
> an empty $(1) against "14.0.0" evaluates 0 < 0 and returns 0 (false).
>
> Pass $(1) and $(2) as separate awk variables and split each into its own
> array so missing components default to 0 without shifting fields across
> arguments.
>
> Fixes: a9b451509565 ("tools build: Add 3-component logical version comparators")
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112011514.4032822-1-irogers@google.com?part=1
next prev parent reply other threads:[~2026-11-12 1:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 22:16 [PATCH v1 0/2] perf build: Support building BPF skeletons with bpf-gcc Ian Rogers
2026-10-13 22:16 ` [PATCH v1 1/2] " Ian Rogers
2026-10-13 22:27 ` sashiko-bot
2026-10-13 22:16 ` [PATCH v1 2/2] perf test make: Add BPF skeleton build tests for clang and bpf-gcc Ian Rogers
2026-10-13 22:23 ` sashiko-bot
2026-10-13 23:14 ` [PATCH v2 0/2] perf build: Support building BPF skeletons with bpf-gcc Ian Rogers
2026-10-13 23:14 ` [PATCH v2 1/2] " Ian Rogers
2026-10-13 23:22 ` sashiko-bot
2026-10-13 23:14 ` [PATCH v2 2/2] perf test make: Add BPF skeleton build tests for clang and bpf-gcc Ian Rogers
2026-10-13 23:24 ` sashiko-bot
2026-10-22 20:46 ` [PATCH v3 0/2] perf build: Support building BPF skeletons with bpf-gcc Ian Rogers
2026-10-22 20:46 ` [PATCH v3 1/2] " Ian Rogers
2026-10-22 20:54 ` sashiko-bot
2026-11-11 6:01 ` Namhyung Kim
2026-10-22 20:46 ` [PATCH v3 2/2] perf test make: Add BPF skeleton build tests for clang and bpf-gcc Ian Rogers
2026-10-22 20:53 ` sashiko-bot
2026-11-04 3:52 ` [PATCH v3 0/2] perf build: Support building BPF skeletons with bpf-gcc Ian Rogers
2026-11-10 22:10 ` Ian Rogers
2026-11-12 1:15 ` [PATCH v4 0/5] " Ian Rogers
2026-11-12 1:15 ` [PATCH v4 1/5] tools build: Fix version-ge3 and version-lt3 for <3-part versions Ian Rogers
2026-11-12 1:18 ` sashiko-bot [this message]
2026-11-12 1:15 ` [PATCH v4 2/5] perf build: Sync bpf_skel.mak get_sys_includes with selftests/bpf Ian Rogers
2026-11-12 1:18 ` sashiko-bot
2026-11-12 1:15 ` [PATCH v4 3/5] perf build: Support building BPF skeletons with bpf-gcc Ian Rogers
2026-11-12 1:15 ` [PATCH v4 4/5] perf test make: Reuse Makefile.feature for libbfd and llvm probes Ian Rogers
2026-11-12 1:32 ` sashiko-bot
2026-11-12 1:15 ` [PATCH v4 5/5] perf test make: Add BPF skeleton build tests for clang and bpf-gcc Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210057@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox