From: sashiko-bot@kernel.org
To: "Ayush Yaduvanshi" <ayush37735@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf/x86/amd/power: Fix missing CPU hotplug setup check and cleanup
Date: Fri, 13 Nov 2026 00:04:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-211974@kernel.org> (raw)
In-Reply-To: <20261112235003.18608-2-ayush37735@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf/x86/amd/power: missing Fixes trailer for commit
c6a84daa3498
--
commit f8ef67a4aa6a417d77c332568d6bad06f58d1c90
Author: Ayush Yaduvanshi <ayush37735@gmail.com>
> perf/x86/amd/power: Fix missing CPU hotplug setup check and cleanup
>
> Check the return value of cpuhp_setup_state() and remove the hotplug
> state if perf_pmu_register() fails.
>
> Signed-off-by: Ayush Yaduvanshi <ayush37735@gmail.com>
[Severity: Low]
This fixes the unchecked cpuhp_setup_state() call and missing error-path
cleanup introduced when the driver was converted to the hotplug state
machine. Should this include:
Fixes: c6a84daa3498 ("perf/x86/amd/power: Convert the hotplug notifier to state machine")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112235003.18608-1-ayush37735@gmail.com?part=1
next prev parent reply other threads:[~2026-11-13 0:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 23:50 [PATCH 0/2] perf/x86/amd: Check CPU hotplug setup and unwind failures Ayush Yaduvanshi
2026-11-12 23:50 ` [PATCH 1/2] perf/x86/amd/power: Fix missing CPU hotplug setup check and cleanup Ayush Yaduvanshi
2026-11-13 0:04 ` sashiko-bot [this message]
2026-11-12 23:50 ` [PATCH 2/2] perf/x86/amd/ibs: Fix missing CPU hotplug cleanup and unchecked init return Ayush Yaduvanshi
2026-11-13 0:01 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211974@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ayush37735@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox