Re: [PATCH v2 01/30] perf pmus: Don't skip core PMUs as duplicates

[sashiko-bot@kernel.org]

> perf_pmus__scan_skip_duplicates() skips a PMU whose name, without a
> numeric suffix, matches the previous PMU's. This is intended for uncore
> PMUs, such as uncore_cha_0 and uncore_cha_1, that have the same events.
> The check was also applied to core PMUs, but core PMUs of heterogeneous
> systems may differ only by such a suffix while having different events.
> For example, ARM ACPI systems with two kinds of core name their PMUs
> armv8_pmuv3_0 and armv8_pmuv3_1, and devicetree systems may name them
> armv8_cortex_a53 and armv8_cortex_a57 where "a53" and "a57" are hex
> suffixes. Only the first core PMU was listed by "perf list" and the
> events of the other core PMUs were missing.
> 
> Before, on such a system, "perf list" and "perf list --unit=<pmu>" only
> showed the events of the first core PMU, the scan having skipped the
> others. After, the events of every core PMU are shown, as on Intel
> hybrid systems with cpu_core and cpu_atom PMUs. Uncore PMU deduplication
> is unchanged and pmu_deduped_name_len() already avoided removing the
> suffix of core PMU names when printing events. Similarly avoid removing
> the suffix of core PMU names in the raw event encodings that "perf list"
> shows for each PMU, so that each core PMU's encoding is shown with its
> own name.
> 
> Fixes: cd4e1efbbc40 ("perf pmus: Skip duplicate PMUs and don't print list suffix by default")
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113195335.2865725-1-irogers@google.com?part=1