Re: [PATCH 03/10] perf jevents: Store PMU names as string literals in struct pmu_table_entry

[sashiko-bot@kernel.org]

> Every PMU table lookup (perf_pmu__find_events_table(), map_for_pmu(),
> pmu_events_table__for_each_event(), pmu_events_table__find_event(),
> pmu_events_table__num_events(), pmu_metrics_table__find_metric()) scans
> table_pmu->pmu_name across PMU table entries to check wildcard matches.
> 
> Across all architectures, there are only 68 unique PMU name strings
> (536 bytes total) across ~443 pmu_table_entry rows (which already reside
> in .data.rel.ro due to their entries pointer). Replace
> struct compact_pmu_event pmu_name in struct pmu_table_entry with a plain
> const char *pmu_name string literal so the compiler and linker merge the
> PMU name strings in .rodata.str1.1 while hot PMU wildcard scans never
> touch big_c_string or trigger block decompression.
> 
> Regenerate empty-pmu-events.c accordingly.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113210822.3112700-1-irogers@google.com?part=3