Re: [PATCH v1 08/26] perf hashmap: Introduce generic types and macros

[sashiko-bot@kernel.org]

> Add DECLARE_HASHMAP(name, key_type, value_type) and type-checked
> hashmap__* wrapper macros around struct __hashmap while keeping legacy
> struct hashmap compatible so callers can be migrated one hashmap at a
> time:
> 
> - Encode key_type and value_type via phantom pointer members in a union
>   with struct __hashmap so wrapper structs preserve identical size and
>   alignment across 32-bit and 64-bit targets, with _Static_assert checks
>   that key_type and value_type fit in a long.
> - Generate typed <name>__new() and NULL-safe <name>__free() helpers,
>   plus pointer-taking hashmap__init(), hashmap__clear(), hashmap__free(),
>   hashmap__size(), hashmap__capacity(), hashmap__insert(),
>   hashmap__add(), hashmap__set(), hashmap__update(), hashmap__append(),
>   hashmap__find(), and hashmap__delete() macros.
> - Marshal output parameters (value_ptr, old_key, old_value) through
>   long-sized temporaries and assign via the declared types so sub-long
>   types (such as bool, int, or pid_t) are safe from stack buffer
>   overflows, endianness bugs, and strict-aliasing violations, while
>   allowing NULL output pointers and const-qualified lookup keys.
> - Implement hashmap__for_each{,_safe}() and
>   hashmap__for_each_key{,_safe}() using single-loop __hashmap_iter and
>   __hashmap_key_iter helpers so 'break' exits the entire iteration,
>   bucket cursors are internal, and element deletion during iteration is
>   safe.
> - Add a 'Generic hashmap' perf test suite exercising integer, string,
>   and sub-long bool/int32 maps, NULL frees, const lookups, early loop
>   breaks, and in-loop deletions.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113214850.3329699-1-irogers@google.com?part=8