Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lalit Maganti" <lalitmaganti@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 4/4] perf python: Compress the traces of the perfetto script
Date: Sun, 15 Nov 2026 00:45:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-215156@kernel.org> (raw)
In-Reply-To: <20261115003916.1873857-5-lalitmaganti@gmail.com>

> Perfetto reads zstd and gzip traces directly, so compress the output by
> default. Add a -c/--compression option:
>  - auto (default): zstd if Python has compression.zstd (3.14+), else
>    gzip, so only the standard library is needed
>  - zstd: level 9
>  - gzip: level 6, with no time or file name in the header so the output
>    is reproducible
>  - none
> 
> Without -o, the output file gets a matching extension: perf.pftrace.zst,
> perf.pftrace.gz or perf.pftrace.
> 
> For 4496 samples of a two-thread workload, the trace is 127KB
> uncompressed, 37KB with gzip and 30KB with zstd. Compressing takes a few
> milliseconds.
> 
> The shell test now checks every compression the Python running it
> supports.
> 
> Assisted-by: LLM
> Signed-off-by: Lalit Maganti <lalitmaganti@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115003916.1873857-1-lalitmaganti@gmail.com?part=4


      reply	other threads:[~2026-11-15  0:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15  0:39 [PATCH 0/4] perf python: Add a script to open profiles in the Perfetto UI Lalit Maganti
2026-11-15  0:39 ` [PATCH 1/4] perf python: Add kernel attribute to callchain_node Lalit Maganti
2026-11-15  0:45   ` sashiko-bot
2026-11-15  0:39 ` [PATCH 2/4] perf python: Add clockid attribute to session Lalit Maganti
2026-11-15  0:44   ` sashiko-bot
2026-11-15  0:39 ` [PATCH 3/4] perf python: Add perfetto script to open profiles in the Perfetto UI Lalit Maganti
2026-11-15  0:53   ` sashiko-bot
2026-11-15  0:39 ` [PATCH 4/4] perf python: Compress the traces of the perfetto script Lalit Maganti
2026-11-15  0:45   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215156@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lalitmaganti@gmail.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox