Re: [PATCH v3 10/12] perf tests: Fix the Intel PT virtual LBR check

[sashiko-bot@kernel.org]

> The record this check uses writes aux samples, and with the single data
> page the other tests ask for they are lost:
> 
>   Warning: Processed 29 samples and lost 100.00%
> 
> so no branches are decoded and the check fails with "Failed with virtual
> lbr".  Record with 4 data pages and 128 auxtrace pages: the same trace
> decodes 64 branches and still fits the mlock budget.
> 
> Require the python perf module to provide session, not just to be
> importable: a perf whose python bindings are not found can pick up an
> unrelated module and fail with
> 
>   Error processing events: module 'perf' has no attribute 'session'
> 
> instead of skipping the subtest.
> 
> Detected building perf on fedora:44 on the runner with Intel PT hardware,
> where the subtest failed with "Failed with virtual lbr" in the container,
> and with the python error when run as root on the same machine.
> 
> Fixes: 915d6b14dc0c ("perf test: Migrate Intel PT virtual LBR test to Python API")
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115014102.2879372-1-acme@kernel.org?part=10